Fix password option #314
Merged
Fix password option #314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This contains a number of fixes for the password option to postgresql_proc: * Use password auth if it's specified, so that the password is actually honored. * Move --pwfile into the options list so that it's passed through to `initdb`; otherwise it causes an error as `pg_ctl` doesn't expect a --pwfile option. * Don't use a shell to run initdb. * Use lists instead of tuples to avoid tuple copying on append. * Flush the password file so that it actually hits disk. * Add unit test to cover the password option.
stpierre
force-pushed
the
stpierre/more-password-fixes
branch
from
05d6d64 to
8bcbe41
Compare
fizyk
approved these changes
Jul 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains a number of fixes for the password option to
postgresql_proc:
actually honored.
initdb; otherwise it causes an error aspg_ctldoesn't expect a--pwfile option.
Fixes #[ISSUE_NUMBER_HERE].
Changes proposed.