Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No sound is played when reloading #14835

Closed
Night-Pryanik opened this issue Jan 13, 2016 · 6 comments
Closed

No sound is played when reloading #14835

Night-Pryanik opened this issue Jan 13, 2016 · 6 comments
Labels
<Bug> This needs to be fixed Other Things that can't be classified anywhere else (S2 - Confirmed) Bug that's been confirmed to exist SDL: Tiles / Sound Tiles visual interface and sounds.

Comments

@Night-Pryanik
Copy link
Contributor

Chezzo soundpack, Win 10, tiles, 0.C-4191.
@Chezzo
Copy link
Contributor

Chezzo commented Jan 13, 2016

I noticed doors opening and closing don't make sounds anymore either.

@Night-Pryanik
Copy link
Contributor Author

Hmm, at least basic wooden and metal doors are opening and closing with sound on 4191.

@mugling
Copy link
Contributor

mugling commented Mar 9, 2016

@Night-Pryanik is this still a problem?

@mugling mugling added the (S1 - Need confirmation) Report waiting on confirmation of reproducibility label Mar 9, 2016
@Night-Pryanik
Copy link
Contributor Author

@mugling yep, there's still no sound of reloading in 0.C-4533.

@mugling mugling added (S2 - Confirmed) Bug that's been confirmed to exist and removed (S1 - Need confirmation) Report waiting on confirmation of reproducibility labels Mar 10, 2016
@illi-kun illi-kun added the <Bug> This needs to be fixed label Jun 7, 2016
@Leland Leland added the Other Things that can't be classified anywhere else label May 8, 2017
@Leland Leland changed the title No sound is heard when reloading No sound is played when reloading Aug 24, 2017
@budg3
Copy link
Contributor

budg3 commented May 31, 2018 •
edited
Loading

This is caused by missing reload_noise_volume for almost all ranged weapons. I've made a PR (#23903) that adds it, but another option would be to change this part in activity_handlers.cpp.

Reload sounds are also currently limited to "type": "GUN" so reloading magazines or gunmods that add grenade launchers, flamethrowers or shotguns etc won't play any sounds.

@Leland Leland mentioned this issue May 31, 2018
Merged
@Leland
Copy link
Contributor

Leland commented May 31, 2018

Closed in #23903

@Leland Leland closed this as completed May 31, 2018
@Leland Leland added the SDL: Tiles / Sound Tiles visual interface and sounds. label May 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
<Bug> This needs to be fixed Other Things that can't be classified anywhere else (S2 - Confirmed) Bug that's been confirmed to exist SDL: Tiles / Sound Tiles visual interface and sounds.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@Leland @Chezzo @illi-kun @Night-Pryanik @mugling @budg3