Option to yell sentences

[AlecWhite]

Asked around in the IRC channel and Discord server if people would like to be able to yell sentence for the role-playing flavour, and they liked it so I decided to make this.

Now you can yell whatever you want at the moose.

• Added "yell sentence" option in chat menu.
• Sentence can be 128 character long and will produce sound.

Had to re-made the if/else which I don't know if I did it right, so I could use some help reviewing that part please.

Also I couldn't decided on how to display the yelled sentence, if either after colon, if forced upper case or between quotation marks. So I left it without any kind of fancy styling.

[BrettDong]

Bad indent.

[DangerNoodle]

I can see this being amusing.

[Leland]

Should be: "Who do you want to talk to or yell at?"

Otherwise, this reads (without the first clause): "Who do you want to yell?"

[Leland]

I haven't checked what the actual UI looks like, but you may not even need to add the "Yell" clause to this.

[AlecWhite]

That text is displayed whether there are NPCs or not, we could add a check to it, but it would automagically tell the player if there are NPCs around.

[codemime]

Since you've touched this line, could you remove it and update the condition below (see #12112)?

[AlecWhite]

I'm sorry, but I don't know exactly what you want me to do, mind explaining it please?

[codemime]

Most of our menus are escapable i.e. they can be closed using Esc button, which makes options like "Cancel" redundant. You can simply remove it to make this particular menu more consistent with the others.

[codemime]

This kind of assignment is ugly and confusing. An enum could have been used here.

[AlecWhite]

I googled around if you can assign an enum's value can be assigned when called, and it seems that they are constant expression. So I don't know how enums can be used in this case.

I could comment more all the code, to it is at least less confusing, but between that I'm a noob at programming and that this method didn't have much comments, I don't really know when to comment and how much to comment.

[codemime]

and it seems that they are constant expression.

They certainly are. I meant getting rid of any assignments entirely. See this function as a good example of what I'm talking about. You can use negative values to avoid overlapping with indexes of NPCs:

    enum class choices {
        just_yell = INT_MIN,
        yell_something,
        ...
    };

[AlecWhite]

Using enum class doesn't seems to work (had to I cast it to int for ui.addentry() to accept it) which for some reason it takes it as zero and one. Using non-class enums works only for the first enum but not for the second as it is taken as 1.

I'm manually assigning them both to -2 and -1 respectively. And it seems that the addentry() and query() both seems to support negative integers.

Any advise?

[BevapDin]

Are negative numbers sorted after non-negative by the game's engine? If no, what you propose won't work.

There is no sorting done by the "game engine" (what do you actually mean with that?) at all. The menu displays the options in the order they have been added (actually: the order in which they appear in uimenu::entries).