Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New semi-dynamic NPC #33828

Merged
merged 9 commits into from Oct 2, 2019
Merged

Conversation

SirPiecemaker
Copy link
Contributor

@SirPiecemaker SirPiecemaker commented Sep 5, 2019

SUMMARY: Content "Adds a new, somewhat dynamic NPC"

Purpose of change

I felt many of the NPC's felt the same in their interactions, so I tried to make an NPC that behaves differently in their interactions with the player, namely conversation and things like scamming them for gear.

Describe the solution

Added an NPC and painstakingly made most of the normal interactions by hand to be unique. While I do have ideas for more for the character, I was afraid people will dislike it and I would waste my time on additional content like it's own, minor faction.

That being said, it got a little out of hand and I ended up making it more interaction-reliant than I intended. It's certainly not Foodperson level, but it might be somewhere in between.

Additional context

Apologies for the probably numerous typos as my keyboard is broken and often fails.

I also want to add that the NPC does not have any special, mystical powers as to not break the setting - it is merely a belief it holds.

Adds new kinda dynamic NPC
Copy link
Contributor

@mlangsdorf mlangsdorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes need to pass travis tests.

data/json/npcs/NPC_Brigitte_LaCroix.json Outdated Show resolved Hide resolved
data/json/npcs/NPC_Brigitte_LaCroix.json Outdated Show resolved Hide resolved
@mlangsdorf mlangsdorf added <Enhancement / Feature> New features, or enhancements on existing [JSON] Changes (can be) made in JSON NPC / Factions NPCs, AI, Speech, Factions, Ownership labels Sep 5, 2019
Co-Authored-By: Mark Langsdorf <mark.langsdorf@gmail.com>
Co-Authored-By: Anton Burmistrov <Night_Pryanik@mail.ru>
Co-Authored-By: Anton Burmistrov <Night_Pryanik@mail.ru>
SirPiecemaker and others added 3 commits September 5, 2019 20:27
Co-Authored-By: Anton Burmistrov <Night_Pryanik@mail.ru>
@SirPiecemaker
Copy link
Contributor Author

Is there anything I should add/change with this PR for merge?

@kevingranade
Copy link
Member

Ok, so they're a crazy person that's obsessed with bones, that's weird but ok.
You gave them a bunch of deprecated bone gear, which is not.
Bone armor of all kinds is obsoleted and on the way out, see #28064

@SirPiecemaker
Copy link
Contributor Author

Ok, so they're a crazy person that's obsessed with bones, that's weird but ok.
You gave them a bunch of deprecated bone gear, which is not.
Bone armor of all kinds is obsoleted and on the way out, see #28064

That was the point - everyone else in the apocalypse seems to be far too logical. This is at least a bit more memorable than just random survivor. As for the armor, don't know what I am supposed to do. Just give her different armor?

Turns out bone armor was made obsolete months ago and was only leftover in the files. Replaced with more generic armor.
@SirPiecemaker
Copy link
Contributor Author

Replaced the bone armor with more generic gear. Please let me know if anything else should be tweaked. Much obliged.

Co-Authored-By: Kevin Granade <kevin.granade@gmail.com>
@kevingranade kevingranade merged commit 24abb24 into CleverRaven:master Oct 2, 2019
@@ -413,7 +413,8 @@
{ "item": "church", "x": [ 14, 18 ], "y": [ 5, 14 ], "chance": 65 },
{ "item": "church", "x": [ 11, 12 ], "y": [ 5, 6 ], "chance": 65 },
{ "item": "jackets", "x": [ 12 ], "y": [ 14 ], "chance": 50 }
]
],
"place_npcs": [ { "chance": 7, "class": "SEER_Brigitte_LaCroix", "x": 18, "y": 6 } ]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, chance is not a supported field in place_npcs (although perhaps it should be), and so this NPC will always spawn here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How else should it be done?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the only way to get a non-certain probability of NPC spawning right now is to use nested mapgen. However, I think adding support for chance is probably the better solution in the long term.

@Brytenwalda
Copy link
Contributor

Does this NPC actually spawn? I’m asking as a modder - how and what conditions are set for this NPC to spawn?

@kevingranade
Copy link
Member

This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there:

https://discourse.cataclysmdda.org/t/is-npc-spawning-a-yes-no-thing/24443/4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Enhancement / Feature> New features, or enhancements on existing [JSON] Changes (can be) made in JSON NPC / Factions NPCs, AI, Speech, Factions, Ownership
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants