-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Magiclysm - Dragon Mutation Add-On #34106
Conversation
There were linting issues with the original one, so I'm going to remove the original and reupload the file straight from my desktop instead of pasting the linted text into the website.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so here are some initial comments about the mutations:
- i feel that thematically, dragons are strong and intelligent. they are not known for their dexterity.
- i would prefer that the breath weapons use the spell infrastructure so you can train it and make it better over time. you can make the mutation teach the spell when you gain it. check out this example
- the mutagen and serum recipes need some work. at the very least you need to kill and successfully butcher an adult dragon of that color to craft it. it is appropriate for the mutagens to be found in treasure hoards. we can just have an item "color_dragon_heart" that is a crafting component. scales can also be an appropriate reagent in addition.
Note: The adult dragons do not currently exist, unfortunately. Therefore, in Magiclysm's current state when this gets added you wouldn't be able to craft these mutagens, only find them. They need their own lairs, so each one will be its own json project.
So i'm going to try and investigate copy-from for mutations. We'll see how difficult that ends up being. |
With the dragon breath, I think it would still be a good mutation to have with an innate attack that also unlocks the spell to cast. The innate attack is aimed as a quick burst of energy while in melee combat and the spell is a more focused/concentrated blast. What do you think about that as a way to implement the mutation? |
yes, so i'm following the dnd colors pretty closely. so red = cone, black, blue = line, etc. |
I haven't forgotten about working on this at all, but life got busy this week. I plan on doing some hefty work on it this weekend, but I think the scope of this PR should be adjusted just to mutagens, the recipe books, and the recipes for the mutagens specifically for black dragons. That, I think, was Kevin's suggestion on Discord and I would like to make this a manageable change for everyone involved. If you would prefer me do this in a particular order KorgGenT I can no problem since this is largely your project. |
that's perfectly fine. you're not on a time limit, either. |
Mutations - added "INT_UP" - "DEX_UP_2" changed to "INT_UP_2" - "DEX_UP_3" changed to "INT_UP_3" - "DEX_UP_4" removed. - "DRAGON_CLAWS": "dex_mod" changed from 1 to -1 - "DRAGON_TAIL": "dodge_modifier" reduced from 2 to 1, "dex_mod" removed, attack damage increased (15 > 25), "chance" decreased (40 > 25). - "WINGS_DRAGON": changed description from "large, dextrous wings that help you move more quickly" to "large, scaled wings that help protect your torso and head" - added "armor" values to "TORSO" and "HEAD" (value 2 for bash, cut, and stab). *I can adjust this for the different dragon types if necessary for the elemental resistances" - reduced "chance" (40 > 30) - "DRAGON_LEGS": removed "dodge_modifier", reduced "strength_damage" from 3 to 2, changed description to remove dextrous comments and add the increased armor values on the legs - added encumbrance 5 to feet and legs. - modified the breath mutations to remove the innate attack, instead referring to them unlocking the breath spells to prime them to be used as the necessary requirement. - fixed attack text errors in the colored horn attack texts, reduced based stab damage from 24 to 15. Mutagens - deleted original... it was all around no good. - recreated mutagen recipe for Black Dragons only (for now). - change recipe book for mutagen to black_dragons recipe book - change recipe book for serum to bdragon_ancient_tome. - changed recipes to require dragon essence and black dragon scales for mutagen, then 2 black dragon mutagens and a "dragon_heart_black" as a placeholder item to change whenever dragon hearts are implemented for serum. Recipe Books - Removed "scientific" books for mutagen recipes. Modified bdragon_ancient_tome to be magical with the serum recipe.
is this pr ready for review? |
So I talked briefly with animethecat, and we will try to resume this PR in March or so. That being said, I will close it until the time comes, as the oddities i've seen aren't easy to reconcile without a clear idea of what the plan is for the mutation tree. |
for some reason it works just by ignoring it I combine the write and codes and copy to paste added the new things in catergory in Magiclysm just press I and the game is still playable with added things. |
Summary
SUMMARY: Mods "Add a dragon mutation line to Magiclysm."
Purpose of change
Adds 4 new mutations lines for Black, Blue, Red, and White dragons each specializing in Acid, Electric, Heat, and Cold damage and resistance, respectively.
Describe the solution
The mutations system works by piggybacking off of mostly preexisting mutations, and adding on both pre and post threshold mutations specific and special to each of the 4 Dragon types.
Describe alternatives you've considered
To be honest, this started with me wanting to make martial arts modeled after Dragon Slayer magic from the anime Fairy Tail, but that just wasn't in the code, while mutations, by and large, were. I also considered making them as spells to add as new schools, but both can exist together without error, and more content is usually always welcome as far as I can tell, so I started here.
Additional context
I was able to test, within my own game on the latest experimental build #9639, if I was able to see the mutation lines present in the debug menu fore preexisting mutations, such as Fangs, Claws, Talons, Nose Slits, etc, and that was successful for each. Additionally I ensured that all books, mutagens, serums, and recipes were present and working properly, including intelligence restrictions. Applied serums, mutagens, and books read all functioned as expected and led to expected results.