Modular saltworks

[Maleclypse]

Summary

Summary: Content "Faction Camp Modular Saltworks"

Purpose of change

Creating an additional modular camp expansion. Modeled after Curstwist's PRs in the same topic.

Describe the solution

Creating additional json files similar the livestock and storage campsite PR's.

Describe alternatives you've considered

Continuing to just make single json edits.

Additional context

"WIP" I've managed to get the game to load without load stopping errors but I can't get the expand base mission to complete successfully and create the modular campsite Saltworks. Any suggestions very welcome.
Once I can get one version to create I plan to create other building material versions and work on the recipe mission list.

I'm pretty ready to close this out but I think I'm going to need some help to finish it in a reasonable timeline.

[Maleclypse]

[Maleclypse]

@curstwist I hate to bother you, but if you have a second to look over this at any time and if you see where I'm going wrong I'd appreciate the help. If no time, no worries I'll muddle through :)

[curstwist]

Looks like you are missing the survey recipe step.

And its mapgen partner. Look at the 1st entries in a _wood recipe &mapgen file. I dont repeat it in other palettes

{
        "type": "recipe",
        "result": "faction_base_workshop_0",
        "description": "Survey land for a workshop area.",
        "category": "CC_BUILDING",
        "subcategory": "CSC_BUILDING_BASES",
        "skill_used": "fabrication",
        "autolearn": false,
        "never_learn": true,
        "construction_blueprint": "faction_base_workshop_0",
        "blueprint_name": "workshop survey",
        "time": "180 m",
        "blueprint_requires": [ { "id": "not_an_upgrade" } ],
        "blueprint_provides": [ { "id": "fbmw_0" } ]
      },

and

{
    "type": "mapgen",
    "method": "json",
    "nested_mapgen_id": "fbmw_0",
    "object": {
      "mapgensize": [ 6, 6 ],
      "rows": [
        "      ",
        "      ",
        "      ",
        "      ",
        "      ",
        "      "
      ],
      "palettes": [ "fbmw_wood_palette" ]
    }
  },
  {
    "type": "mapgen",
    "update_mapgen_id": "faction_base_workshop_0",
    "method": "json",
    "object": { "place_nested": [ { "chunks": [ "fbml_0" ], "x": 15, "y": 3 } ] }
  },

that little mapgen really doesn't do anything to the map, but I got errors if I left it out, the survey wants an update_mapgen_id.

[Maleclypse]

Looks like you are missing the survey recipe step.

And its mapgen partner. Look at the 1st entries in a _wood recipe &mapgen file. I dont repeat it in other palettes

{
        "type": "recipe",
        "result": "faction_base_workshop_0",
        "description": "Survey land for a workshop area.",
        "category": "CC_BUILDING",
        "subcategory": "CSC_BUILDING_BASES",
        "skill_used": "fabrication",
        "autolearn": false,
        "never_learn": true,
        "construction_blueprint": "faction_base_workshop_0",
        "blueprint_name": "workshop survey",
        "time": "180 m",
        "blueprint_requires": [ { "id": "not_an_upgrade" } ],
        "blueprint_provides": [ { "id": "fbmw_0" } ]
      },

and

{
    "type": "mapgen",
    "method": "json",
    "nested_mapgen_id": "fbmw_0",
    "object": {
      "mapgensize": [ 6, 6 ],
      "rows": [
        "      ",
        "      ",
        "      ",
        "      ",
        "      ",
        "      "
      ],
      "palettes": [ "fbmw_wood_palette" ]
    }
  },
  {
    "type": "mapgen",
    "update_mapgen_id": "faction_base_workshop_0",
    "method": "json",
    "object": { "place_nested": [ { "chunks": [ "fbml_0" ], "x": 15, "y": 3 } ] }
  },

that little mapgen really doesn't do anything to the map, but I got errors if I left it out, the survey wants an update_mapgen_id.

Thanks! I'll work on that this week.

[Maleclypse]

Some screenshots?

I edited the descriptions. I also noticed that the brewery upgrade is failing and not calculating the components needed to build so if anyone has any suggestions on how to fix that I'm open to them. I'll turn this back into WIP until I get that resolved. When I tested it the first time I just got them all built to first level.

[Maleclypse]

@curstwist were you having issues with upgrades to existing buildings and that's why you stopped making basecamp upgrades until it was resolved? I can't remember.

[curstwist]

@curstwist were you having issues with upgrades to existing buildings and that's why you stopped making basecamp upgrades until it was resolved? I can't remember.

I stopped until the rotation issue is fixed (there's a PR up that should fix it) and using the expansion upgrade craft recipies in the "core" building, which isn't working. Since this is a proper expansion, it shouldn't be either of my issues. I'll take a look at it.

[curstwist]

You can also use "amount": ..either should work.

[Maleclypse]

I'm not sure what the following means
src/json.cpp:111: Failed to visit member 'faction_owner' in JsonObject at line 2480:78509: { "type": "mapgen", "om_terrain": "faction_base_saltworks_0", "method": "json", "faction_owner": { "id": "your_followers", "area": [ { "x": 0, "y": 0, "x2": 23, "y2": 23 } ] }, "weight": 250,

[curstwist]

Faction_owner needs to be within the object section. They were all wrong but jbtw recently fixed the others.

[AMurkin]

Shouldn't faction_owner be inside object?

[curstwist]

excludes id is still misspelled. should be identical to requires.

[Maleclypse]

I'm seeing a bunch of gunmod errors in my C and Travis tests but not anymore errors from files I edited. Tomorrow I'll see if I can get the brewery upgrades to work and I'll post screenshots of them assuming they do.

[Maleclypse]

@curstwist this might just need another set of eyes or maybe I should take a break for the day on it but I've got all the material types building all the way through except for the final brewery upgrade on metal and wad types. I've also solved my issue where it would offer me to change material types in the base construction screen, I'm not sure if it was the most elegant solution but it seems to have worked by editing the blueprint excludes line.

[Maleclypse]

Image of completed all materials versions here in Camp Salty. Top left has a basic brewery, bottom right has upgraded brewery by one level. All other breweries are level 2. Left is log, top left is stone, north is metal, top right is wattle and daub, right is wood.