Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSONize Sewage Treatment Plant #33339

Merged
merged 13 commits into from
Aug 20, 2019
Merged

Conversation

anothersimulacrum
Copy link
Member

Summary

SUMMARY: Content "Jsonify sewage treatment plant"

Purpose of change

(Note, this entire PR description is copied from #32678, which this obsoletes)
Sewage plant was old, hardcoded and nonrotatable.

Describe the solution

Jsonified the plant and completely remade into rotatable 2x2 building with 3x2 basement.

Describe alternatives you've considered

Leave everything as is.

Additional context

Sulfuric acid, quicklime and sodium hypochlorite are pretty common chemicals on IRL sewage treatment plants, so I added them.
sewage1
sewage2

This is the same as #32678, except the branch is clean - I asked @chaisawlajatang about it and was told he didn't mind if I made it from my name.
This work is entirely @Petethegoat and Chainsawlajatangs, not mine.

@ZhilkinSerg ZhilkinSerg added [C++] Changes (can be) made in C++. Previously named `Code` [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display labels Aug 18, 2019
@ZhilkinSerg ZhilkinSerg merged commit a2ed049 into CleverRaven:master Aug 20, 2019
@anothersimulacrum anothersimulacrum deleted the sewage branch August 20, 2019 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants