Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Light Manipulation Spellbook, and new relic effect "BONUS_DODGE" #35925

Merged
merged 7 commits into from
Dec 17, 2019

Conversation

John-Candlebury
Copy link
Member

@John-Candlebury John-Candlebury commented Dec 7, 2019

Summary

SUMMARY: Mods "Adds new spell and light manipulation themed spellbook"

Purpose of change

Noticed that Magiclysm already had a lot of light manipulation spells, but had no themed spellbook for them.

Describe the solution

The book "Of Light and Falsehoods" will cover all your current photomancy needs.

This also adds a new spell that increases dodge attemptsthrough light manipulation, and two enchanted rings that share this effect

@John-Candlebury John-Candlebury added [JSON] Changes (can be) made in JSON Mods: Magiclysm Anything to do with the Magiclysm mod Mods Issues related to mods or modding labels Dec 7, 2019
@KorGgenT KorGgenT self-assigned this Dec 7, 2019
@KorGgenT
Copy link
Member

KorGgenT commented Dec 7, 2019

Notes:

  • add a spell scroll for that new spell
  • BONUS_DODGE does not currently have an implementation, see Enchantment Values (Organization) #33837. it should be somewhat easy if you find the places that dodge gets calculated and call the enchantment function there.

@John-Candlebury
Copy link
Member Author

Thanks KorGgenT!
I'll mark this as a WIP until I implement BONUS_DODGE.

@John-Candlebury John-Candlebury changed the title Light Manipulation Spellbook [WIP] Light Manipulation Spellbook Dec 7, 2019
@John-Candlebury
Copy link
Member Author

Implemented BONUS_DODGE modifier. This should be ready for review once again.

@John-Candlebury John-Candlebury changed the title [WIP] Light Manipulation Spellbook Light Manipulation Spellbook Dec 7, 2019
@KorGgenT
Copy link
Member

KorGgenT commented Dec 8, 2019

so with a brand new character, this is my dodge:
image
then i cast the spell and get this:
image
i change my dodge skill to 9:
image
and then i get this:
image

what do you think? should this be the standard behavior for this artifact effect? that's pretty dang strong for +100%... and it doesn't appear to exactly be +100% anyway. (which is the more weird thing)

@KorGgenT
Copy link
Member

KorGgenT commented Dec 8, 2019

I originally wanted to increase or decrease the number of dodges available, like martial arts do, but maybe the name of that value is a little misleading. it's still in the early stages so i can call that something else if you think increasing your dodging ability is more intuitive for this value

@John-Candlebury
Copy link
Member Author

Yeah it was certainly too strong. Just changed the bonus to a flat +2 levels. Which is still rather strong.

I honestly think both effects do different things worth having. Increasing dodge attempts is mostly useful and more valuable for characters who fight in melee range, while increasing actual dodge skill is also usefull for characters that would rather nor get hit at all but that might occasionally find themselves in melee range (pure mages mostly).

A direct increase of dodge skill also better simulates Dnd Mage Armor spell too.

@John-Candlebury John-Candlebury changed the title Light Manipulation Spellbook Light Manipulation Spellbook, and new relic effect "BONUS_DODGE" Dec 9, 2019
@KorGgenT KorGgenT merged commit e21d497 into CleverRaven:master Dec 17, 2019
@John-Candlebury John-Candlebury deleted the spells branch December 20, 2019 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[JSON] Changes (can be) made in JSON Mods: Magiclysm Anything to do with the Magiclysm mod Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants