Weekly Digest (15 December, 2019 - 22 December, 2019) #36345

weekly-digest · 2019-12-22T11:00:12Z

Here's the Weekly Digest for CleverRaven/Cataclysm-DDA:

ISSUES

Last week 218 issues were created.
Of these, 158 issues have been closed and 60 issues are still open.

OPEN ISSUES

💚 #36336 Weird binary in recent commits on i686 arch, by tim77
💚 #36334 add tiaras and necklaces, by curstwist
💚 #36333 Replace weight int with string in mods, by anothersimulacrum
💚 #36327 Option to change position of "look around" and "aim" windows, by Kilvoctu
💚 #36326 Add font glyph fallback mechanism to the tiles build, by Qrox
💚 #36325 Add Triffid flowers, by arijust
💚 #36324 refresh look_around appearance, by captnblood
💚 #36322 Fixed safemode doesn't work if compass is hidden #36236, by ipcyborg
💚 #36321 Military and police roadblocks should be visible on the overmap, by SirPendrak
💚 #36315 Initial code for improvements of the water faucet., by gregoranders
💚 #36314 Risky Terrain Legacy Mode, by Muntari
💚 #36313 Auto travel is unreliable in forests while riding a horse, by ymber
💚 #36312 Saddle evaporates when horse dies, by ymber
💚 #36310 Crafting uses best item available, by Berkyjay
💚 #36309 Multiple Bike rack conflict, by Gremilcar
💚 #36308 Allsporting Group revamp, by LilShiningMan
💚 #36307 Adds Modern house no.2, by John-Candlebury
💚 #36306 look_around refresh proposal, by captnblood
💚 #36305 De-nest itemgroup accesories_personal_unisex, by Soup-de-Loop
💚 #36302 Calorie adjustment: Fish portions, by Zourin2
💚 #36301 Aftershock:Wraitheon Executive Profesion, by John-Candlebury
💚 #36297 Keybindings "Reload Item" and "Reload Wielded Item" do the same thing, by CoroNaut
💚 #36295 Edited Amorphous Body mutation description, by KayoKake
💚 #36292 Jsonize unarmed cut and bash damage from mutations, by Fris0uman
💚 #36291 NPC attacks player through Z-level, by Xenotrenium
💚 #36287 WIP Mr Lapin NPC Warrener, by Maleclypse
💚 #36284 more variety is SUS shelter items, by Jerimee
💚 #36282 more variety in shelter_supplies, by Jerimee
💚 #36281 add FN F2000, by LZhangy
💚 #36279 The rotating charges of a few consumable items in profession choosing, by ThomasLinkin
💚 #36277 Monomolecular blade does not use cutting skill, by vlad1492
💚 #36276 Swappable storage batteries require metal saw, by vlad1492
💚 #36270 Remove unnecessary uses of "charges" in item definitions and recipes, by I-am-Erk
💚 #36263 Check for rotten components before starting craft, by davidpwbrown
💚 #36257 Clear screen after world/options menu close to clean up graphical artifacts, by mark7
💚 #36255 WIP: Flyer snippets lore update, by I-am-Erk
💚 #36247 Update Graphical Overmap mod to support buildings from some other mods, by Kilvoctu
💚 #36238 [CR]Set pathfinding avoid_traps to true by default, by davidpwbrown
💚 #36236 safemode doesn't work if compass is hidden, by captnblood
💚 #36235 Allow defining anonymous itemgroups in mapgen, by ymber
💚 #36233 [WIP] Add fitness band and heartrate function for character, by CountAlex
💚 #36231 Bamboo as a versatile renewable resource, by new02DAY
💚 #36225 Mass Zombie Suicide due to Damaging Tiles, by Curt5
💚 #36220 Allow defining a binomial distribution for item spawn quantities, by ymber
💚 #36218 Rework item spawns in mapgen to use the new itemgroup system, by ymber
💚 #36206 Refactor inventory item menu, by KorGgenT
💚 #36205 refactor drop activity and associated functions, by KorGgenT
💚 #36200 Jsonize autodoc couch, by Fris0uman
💚 #36194 Add alternative end evolutions to skeletons, by arijust
💚 #36190 The amazing teleporting hulk, by anothersimulacrum
💚 #36180 Survivor Utility Belt reporting (poor fit) and not allowing tool use even when fitted., by CypherHyena
💚 #36174 Spells cast by monsters count as cast by player, by LaVeyanFiend
💚 #36172 Crafting menu shows range of possible nutrients for food crafts, by jbytheway
💚 #36171 Many mods have json errors that need to be cleared up, by jbytheway
💚 #36160 Mi-go furnitures contain a fetid goop that can mask your scent, by Fris0uman
💚 #36153 Unload all in tile, by glenmack
💚 #36151 Make interrupt messages being an option to turn on/off, by Unrepentant-Atheist
💚 #36130 Map autonotes have to be configured every time a world is reset/generated, by Amoebka
💚 #36126 Missing mutation interaction, by Bulletfang
💚 #36124 Mapgen: Minimum distance to same overmap special, by glenmack

CLOSED ISSUES

LIKED ISSUE

👍 #36170 Allow random tile variants for immobile furniture, by ralreegorganon
It received 👍 x3, 😄 x0, 🎉 x6 and ❤️ x0.

NOISY ISSUE

🔈 #36138 SIGSEGV processing items on map, by ymber
It received 15 comments.

PULL REQUESTS

Last week, 168 pull requests were created, updated or merged.

OPEN PULL REQUEST

Last week, 2 pull requests were opened.
💚 #36325 Add Triffid flowers, by arijust
💚 #36308 Allsporting Group revamp, by LilShiningMan

UPDATED PULL REQUEST

Last week, 34 pull requests were updated.
💛 #36307 Adds Modern house no.2, by John-Candlebury
💛 #36305 De-nest itemgroup accesories_personal_unisex, by Soup-de-Loop
💛 #36295 Edited Amorphous Body mutation description, by KayoKake
💛 #36292 Jsonize unarmed cut and bash damage from mutations, by Fris0uman
💛 #36287 WIP Mr Lapin NPC Warrener, by Maleclypse
💛 #36281 add FN F2000, by LZhangy
💛 #36263 Check for rotten components before starting craft, by davidpwbrown
💛 #36257 Clear screen after world/options menu close to clean up graphical artifacts, by mark7
💛 #36255 WIP: Flyer snippets lore update, by I-am-Erk
💛 #36238 [CR]Set pathfinding avoid_traps to true by default, by davidpwbrown
💛 #36235 Allow defining anonymous itemgroups in mapgen, by ymber
💛 #36206 Refactor inventory item menu, by KorGgenT
💛 #36205 refactor drop activity and associated functions, by KorGgenT
💛 #36200 Jsonize autodoc couch, by Fris0uman
💛 #36172 Crafting menu shows range of possible nutrients for food crafts, by jbytheway
💛 #36160 Mi-go furnitures contain a fetid goop that can mask your scent, by Fris0uman
💛 #36107 Add warning if attempting to keep world, by AlexMooney
💛 #36102 Colored selected item and extended win for long items name, by 8street
💛 #36089 Reworked how crafting skill requirement display is generated., by ishtatann
💛 #36074 Add "forbidden traits" to professions , by np-vortex
💛 #36037 Options to allow previous behavior around prompt for dangerous terrain, by Ramza13
💛 #35997 Add new mapgen location - private resort., by CountAlex
💛 #35921 Leech pod monster family, by John-Candlebury
💛 #35792 [WIP] Graphical Overmap update, by Larwck
💛 #35752 [CR] Update Modular Turrets and Salvaged Robots to match Mainline style and recipes Fixes #35689, by CSHague
💛 #35658 Magiclysm - Golems, by arijust
💛 #35546 Rework no religious texts mod as a migration, by kevingranade
💛 #35545 Add stub code for applying migrations to downstream item lists., by kevingranade
💛 #35272 Adding More Furniture, by WhaleyWhaley
💛 #35238 Added 2 new NPCs., by LovamKicsiGazsii
💛 #34690 Towing vehicles, by davidpwbrown
💛 #34540 Fix curry/chili powder substitutions, by lazho
💛 #34246 [WIP]NPC and player auto-crafting from workbench bills, by davidpwbrown
💛 #33271 [CR] Removed penalties and base cost when calculating obtain_cost() for wielded item, by Raschert0

MERGED PULL REQUEST

COMMITS

Last week there were 290 commits.
🛠️ Update mammal.json by Maleclypse
🛠️ Replace volume ints with strings for furn and ter (#36328) Volume strings specifying the units are more readable and easily
understandable, so they should be used instead of raw ints. by anothersimulacrum
🛠️ Remove the speed debuff when the temp is low by FuelType-Memes
🛠️ Plural name fixes by BrettDong
🛠️ clear stashed activity on assign new and neaten up assign activities by davidpwbrown
🛠️ Merge pull request #36311 from sztosz/fix-#36303 Fix numer of carrots needed for 3L pickled veggies jar by Rivet-the-Zombie
🛠️ Fix numer of carrots needed for 3L pickled veggies jar by sztosz
🛠️ Appease clang by anothersimulacrum
🛠️ [add rings and bracelets (#36278) * add rings and bracelets

update name strings
lint
Update jewelry.json](bfb1fcc) by curstwist
🛠️ Reduce scope of variable. Mostly just make new variables within the blocks. This avoids the need to clear the variable each time. And sometimes just use the string directly. by BevapDin
🛠️ Add some helper functions by BevapDin
🛠️ Use std::string instead of std::ostringstream Slightly changed some statements as to combine multiple adjacent writes of string literals into a single string literal. Also used colorize to get a std::string, to which other string literals can be added. by BevapDin
🛠️ [Remove extras: field from overmap specialls (Remove extras: field from overmap specialls #36298) * Remove extras: field from overmap specialls
Format JSON's](0bac1c9) by sztosz
🛠️ Add vitamin flags, other contents to food display Add flags to vitamins, so that vitamins can have different effects without requiring entirely new members. Add FOOD_VIT_EFFECTS to item info, which displays vitamins that are not of subtype vitamin, because these things are not used as vitamins, but instead have other effects within food. Some 'vitamins' should not be display, so add a NO_DISPLAY flag that can be used to exclude them from display. by anothersimulacrum
🛠️ [Fix up elevators and their controls (Fix up elevators and their controls #36179) * Fix up elevators and their controls

If there are monsters in an elevator with you, they come along for the
ride. If there are monsters in an elevator at the destination, push
them out of the way before arrival.

Let all creatures ride along in elevators
Refactor elevator code
Fix bug of pushing player out of elevator
Fix elevator blocked by critters at destination](f1e683c) by AlexMooney
🛠️ turret/vehicle ammo fix based on research (#36083) by misterprimus
🛠️ [Only apply speed penalty from heat to main body parts (Only apply speed penalty from heat to main body parts #36289) * Only apply speed penalty from heat to torso and head
Only apply penalty to main parts](b3061ff) by Fris0uman
🛠️ Merge pull request #36299 from anothersimulacrum/str-pl Fix survival kit plural string by ZhilkinSerg
🛠️ Merge pull request #36288 from Qrox/fix-translation Fix two incorrect gettext calls by ZhilkinSerg
🛠️ Fix survival kit plural string by anothersimulacrum
🛠️ item groups sort - food and locations list (#36290) moved item lists from item_groups to food and locations.json by LilShiningMan
🛠️ Append string outside gettext calls by Qrox
🛠️ Merge pull request #36274 from BevapDin/rnh Extend automatic mod checking: by ZhilkinSerg
🛠️ Surgery don't hurt part if parent part has already been hurt (#36203) by Fris0uman
🛠️ Merge pull request #36283 from Qrox/martial-selection-show-stats Display player stats in the martial arts selection menu during character creation by ZhilkinSerg
🛠️ Merge pull request #36213 from kevingranade/jan-2019-changelog Dec 2019 changelog by Rivet-the-Zombie
🛠️ Display player stats in the martial arts selection menu during character creation by Qrox
🛠️ Remove phantom bread recipes (#36275) by LaVeyanFiend
🛠️ [Fix NPCs running out of stamina (Fix NPCs running out of stamina #36252) NPC stamina should not be being drained, but for some reason it was.
Refactor how stamina is modified to always use mod_stamina(), and make
sure that NPC stamina is not modified through this.

No message for sleeping player
pain immune players can watch
limit to 5 messages per surgery phase
Pain immune players don't pass out (flavour only)](a077dbb) by Fris0uman
🛠️ [Fix trade items disappearing when counted by charges (Fix trade items disappearing when counted by charges #36267) * store charges to remove
remove var after using](71f2f79) by davidpwbrown
🛠️ Fix astyle regression by ZhilkinSerg
🛠️ Reduce save game size by not storing default values by BevapDin
🛠️ [Dry/Fieldstone walls (Dry/Fieldstone walls #36195) * Terrain and Construction
Appropriate skill levels

and correct spacing

Update construction.json
adds pebbles, lowers str, changes text halfwall
Update data/json/furniture_and_terrain/terrain-walls.json

Co-Authored-By: I-am-Erk 45136638+I-am-Erk@users.noreply.github.com

Update data/json/furniture_and_terrain/terrain-walls.json

Co-Authored-By: I-am-Erk 45136638+I-am-Erk@users.noreply.github.com](5bbd2b5) by Maleclypse
🛠️ [Tameable reproducing rabbits (#36253) * Update mammal.json

Update baby timer

Checked time for rabbits to mature and adjusted to not assume rabbits start cataclysm pregnant.](c7b15b0) by Maleclypse
🛠️ Milspec Searchlight recipe (#36264) by Fris0uman
🛠️ [Mod cleanup: no_fungi mod (#36189) * Remove no_fungi mod from blacklist

Add missing spaces
Fix weights.
Fix region overlay.

Attempt 1.

Revert](77eb9d5) by arijust
🛠️ [Vehicle crash reverse fix (Vehicle crash reverse fix #36266) * check autodriving before stop autodriving
encapsulate in stop autodriving function](7d2bd18) by davidpwbrown
🛠️ [Add feline_ears mutation to arsonist (Add feline_ears mutation to arsonist #36258) * Add feline_ears mutation to arsonist
Tweak to traits for arsonist.](25cef38) by arijust
🛠️ [Gem stones part 1 (Gem stones part 1 #36169) * add gems, earring, dental grills.
add starter item groups
update gems with copy-from
fix spelling
add copy-from for earirngs/dental grills.

also adjust weight to 2700mg. A caret of any gem weigh .2 g. Simple post & stud earrings generally weigh 2.5 g. I used mg to avoid decimals.

adjust weight of gems
adjust gem volume

I've made these 6ml, .36 of a cubic inch.

copy-from fix](d344a8e) by curstwist
🛠️ Merge pull request #36259 from Qrox/exclude-dda Exclude dda in unit test mod list to fix CI build errors by ZhilkinSerg
🛠️ Merge pull request #36261 from ZhilkinSerg/astyle-2019-12-19 Fix astyle regression (2019-12-19) by ZhilkinSerg
🛠️ Fix astyle regressions by ZhilkinSerg
🛠️ [Limit time taken for NPCs to train new spells (Limit time taken for NPCs to train new spells #36217) * limit time taken for spell trianing new spells
modify comments
use clamp instead of maxmin](fc8d267) by davidpwbrown
🛠️ Merge pull request #36223 from davidpwbrown/generic_video_game Generic video game play iuse by ZhilkinSerg
🛠️ Merge pull request #36227 from BevapDin/ywh Replace usage of JsonArray::has_more with range-based loops. by ZhilkinSerg
🛠️ Check for possible to wield completed craft (#36230) by davidpwbrown
🛠️ Allow autoboating (#36221) by davidpwbrown
🛠️ Merge pull request #36260 from davidpwbrown/reload_pull_fix Change pull metal weapon mattack to cancel reload activity by ZhilkinSerg
🛠️ Merge pull request #36237 from KorGgenT/nopain Magiclysm - spells go through pain resist by ZhilkinSerg
🛠️ Merge pull request #36256 from Night-Pryanik/crafting-gui-borders-fix Fixed crafting GUI borders issues by ZhilkinSerg
🛠️ [Fix for liquid handling during butchery after interruption (Fix for liquid handling during butchery after interruption #36245) * activity is cancelled after liquid handling - dont access targets
extra line deletion
add comment to explain danger](8208210) by davidpwbrown
🛠️ Merge pull request #36251 from mark7/wb-noopt Add NOOPT make option to disable optimization by ZhilkinSerg
🛠️ Fix field coverage error by Qrox
🛠️ change pull metal weapon mattack to cancel reload activity by davidpwbrown
🛠️ Exclude dda in unit test mod list by Qrox
🛠️ Add NOOPT make option to disable optimization GCC recommends use of -Og for debug builds, which theoretically disables optimizations that will cause problems for debugging, but leaves some on to improve performance. Presently, in non-release builds, the Makefile always uses -Og if supported by the compiler. Unfortunately, it appears that even -Og permits control flow to -- from the standpoint of someone using a debugger -- not step a single line at a time when stepping, as lines may have been optimized out. Provide a make option NOOPT, so that if someone really needs -O0 builds, they can get them from the command line without patching the Makefile each time (and possibly letting that change slip into pull requests). by mark7
🛠️ Fixed crafting GUI borders issues by Night-Pryanik
🛠️ Merge pull request #36226 from LaVeyanFiend/MoreSteelPlate Add more steel lining clothing mod compatibility to thick clothing by Rivet-the-Zombie
🛠️ Merge pull request #36246 from anothersimulacrum/fix-pulp Fix pulping not working by ZhilkinSerg
🛠️ Merge pull request #36243 from davidpwbrown/drunk_balance Modify alcohol values to be in line with 1-second turns by ZhilkinSerg
🛠️ Merge pull request #36241 from davidpwbrown/vehicle_collision_stop_autodrive Stop autodrive on any collision, not just damaging ones by ZhilkinSerg
🛠️ Merge pull request #36250 from Qrox/avoid-iterator-invalidation Avoid potential iterator invalidation in map::process_items by ZhilkinSerg
🛠️ Merge pull request #36244 from ralreegorganon/map-extra-spawn-debug-list Add new debug menu item for checking map extra spawns by ZhilkinSerg
🛠️ [(done)Tweak appearance rates of new mapgen extras ((done)Tweak appearance rates of new mapgen extras #36240) * decrease boulders, decrease extras overall
further tweaks based on Wist's tests](f8f2f00) by I-am-Erk
🛠️ [20 or so fairy tale descriptions (20 or so fairy tale descriptions #36248) * Update misc.json
Update misc.json
Update misc.json
Update data/json/items/book/misc.json

Co-Authored-By: I-am-Erk 45136638+I-am-Erk@users.noreply.github.com

Update data/json/items/book/misc.json

Co-Authored-By: I-am-Erk 45136638+I-am-Erk@users.noreply.github.com

Update data/json/items/book/misc.json

Fix trait conflict at character creation
Shorter mod description
exclude robust genetic](572b78f) by Fris0uman
🛠️ Merge pull request #36215 from CleverRaven/android-build-2019-12-18-v2 Report Android tools version during build by ZhilkinSerg
🛠️ Report Android tools version during build by ZhilkinSerg
🛠️ Merge pull request #36214 from Night-Pryanik/search-radius Revert limiting search radius for listing bionics to 3 tiles by ZhilkinSerg
🛠️ Revert limiting search radius ro 3 tiles by Night-Pryanik
🛠️ Copyedit new changelog entries. by kevingranade
🛠️ Automated changelog import through Dec 01, 2019 by kevingranade
🛠️ Merge pull request #36209 from John-Candlebury/sci-fi-aftershock Remove dough from aftershock by Rivet-the-Zombie
🛠️ Merge pull request #36211 from anothersimulacrum/amk Fix alt map key after #36075 by ZhilkinSerg
🛠️ Merge pull request #36212 from CleverRaven/android-typo-2019-12-18 Fix typo in variable name in gradle file by ZhilkinSerg
🛠️ Fix typo in variable name in gradle file by ZhilkinSerg
🛠️ Fix alt map key and graphical overmap after #36075 Also add alt map key to mod testing to prevent this. Graphical overmap needs mod font support to be able to be run with CI. by anothersimulacrum
🛠️ Obsolete recipes by John-Candlebury
🛠️ Remove dough from aftershock by John-Candlebury
🛠️ Get rid of MISC_REPAIR iuse action and resin_cord item (#36155) by ZhilkinSerg
🛠️ Fix not displaying mutant + cbm encumbrance (#36121) by Ramza13
🛠️ Ellipsis preferred over three dots by ZhilkinSerg
🛠️ Merge pull request #36196 from kevingranade/fix-vertical-peeking Only allow vertical view shifting when 3D FOV is enabled by ZhilkinSerg
🛠️ Merge pull request #36199 from ZhilkinSerg/android-2019-12-18 Updated Android build process (2019-12-18) by ZhilkinSerg
🛠️ More build customizations from properties file by ZhilkinSerg
🛠️ [(done) Removes long grass from regional terrain lists, makes it into a map extra ((done) Removes long grass from regional terrain lists, makes it into a map extra #35990) * add json-based map extras for fields
add shed
adjust frequencies based on playtest
add new extras to forests too
reduce trees and bushes in fields](4206b62) by I-am-Erk
🛠️ Mod cleanup: Fix special attacks and death functions (#36186) by ZhilkinSerg
🛠️ change parameter of plthrow from int to item_location (#36106) by KorGgenT
🛠️ refactor mend() (#36173) by KorGgenT
🛠️ Unconditionally update overmap vision (#36183) by ymber
🛠️ Merge pull request #36192 from KorGgenT/minor-blacklist-fix Mod Cleanup: fix external_option errors by I-am-Erk
🛠️ Merge branch 'master' into minor-blacklist-fix by KorGgenT
🛠️ Merge pull request #36191 from ZhilkinSerg/android-2019-12-16 Flavor-aware app name by ZhilkinSerg
🛠️ Merge pull request #36185 from ZhilkinSerg/mods-json-assorted-2019-12-17 Mod cleanup: Assorted fixes (2019-12-17) by I-am-Erk
🛠️ Merge branch 'master' into mods-json-assorted-2019-12-17 by I-am-Erk
🛠️ change Character::change_side parameter to item_location by KorGgenT
🛠️ move player::change_side to Character by KorGgenT
🛠️ [Light Manipulation Spellbook, and new relic effect "BONUS_DODGE" (Light Manipulation Spellbook, and new relic effect "BONUS_DODGE" #35925) * Magiclysm- Light Manipulation Spellbook
Add spell scroll
Implement BONUS_DODGE
Modify dodging bonus
Lint Json
Rework Bonus Dodge to add dodge attempts

Also adds two new rings with this effect

minor adjustment](e21d497) by John-Candlebury
🛠️ Merge pull request #36181 from Maleclypse/AFS-Prepnet-Orchard-MapSpecial Afs prepnet orchard map special by I-am-Erk
🛠️ Merge pull request #36177 from Maleclypse/Mortar-to-Stone Mortar to stone by I-am-Erk
🛠️ Merge pull request #36184 from ZhilkinSerg/mods-json-whitespaces Mod cleanup: Fix insufficient spaces by I-am-Erk
🛠️ Merge pull request #36188 from ZhilkinSerg/mods-json-item-groups Mod cleanup: Fix item groups by I-am-Erk
🛠️ Mod cleanup: Assorted mapgen fixes (2019-12-17) (#36187) by ZhilkinSerg
🛠️ fix external_option errors by KorGgenT
🛠️ Update refugee_item_groups.json by ZhilkinSerg
🛠️ Update captive_item_groups.json by ZhilkinSerg
🛠️ Fix item groups (chance -> prob) by ZhilkinSerg
🛠️ Update CRT_EnforcementBuff.json by ZhilkinSerg
🛠️ Fixed uncraft recipes by ZhilkinSerg
🛠️ Fix terrain id in regional overlay by ZhilkinSerg
🛠️ Removed unused nodes from regional overlay by ZhilkinSerg
🛠️ Removed unused type node from city node in regional overlay by ZhilkinSerg
🛠️ Removed unused use_message node from place_monster use action by ZhilkinSerg
🛠️ Fixed recipe overrides by ZhilkinSerg
🛠️ Removed unused scaled_num node from cactus harvest by ZhilkinSerg
🛠️ Removed unused range node frpm monster special attacks by ZhilkinSerg
🛠️ Fix copy-from by ZhilkinSerg
🛠️ Renamed comment node by ZhilkinSerg
🛠️ Fix skill requirements for melee techniques by ZhilkinSerg
🛠️ Fix insufficient spaces by ZhilkinSerg
🛠️ Merge pull request #36100 from davidpwbrown/camp_upgrade_vehicle_fixes Camp upgrade vehicle fixes by Rivet-the-Zombie
🛠️ Update afs_overmap_specials.json by Maleclypse
🛠️ Standardize player info window colors/format Previously, the colors and format used on the player info window had varied from tab to tab. Make all tabs conform to the color convention used in the STATS tab: Magenta is reserved for text that must be set off from the rest, white for numeric stats to make them stand out, light gray for everything else. Convert "sentence"-based structure of ENCUMBRANCE AND WARMTH tab to one-line-per-stat format. by mark7
🛠️ Merge pull request #36176 from KorGgenT/mag-it-group fix demon lair itemgroup by I-am-Erk
🛠️ Merge pull request #36167 from arijust/headlight_fix Change weight for reinforced wide highlights. by I-am-Erk
🛠️ Only allow vertical view shifting when 3D FOV is enabled by kevingranade
🛠️ Merge pull request #36170 from ralreegorganon/random-tiles-for-immobile-furniture Allow random tile variants for immobile furniture by kevingranade
🛠️ Don't paralyze when cleaning a filthy gun (#36158) by AlexMooney
🛠️ Update afs_overmap_specials.json by Maleclypse
🛠️ [Colour-code ter and furn prereqs for constructions (Colour-code terrain and furniture prerequisites for constructions #36145) Some constructions require the existence of a particular terrain or
furniture to build. E.g. "door with peephole" requires "door".

The other construction requirements are highlighted in red or green
according to their presence. Make this one highlighted similarly, so
that it is clear when it is the reason that a particular construction is
impossible.](d46a122) by jbytheway
🛠️ Retire procedurally generated houses and basements (#36075) by ralreegorganon
🛠️ allow "internal" wearables even with skin-contact gear on top (#36062) by misterprimus
🛠️ Merge pull request #36016 from KorGgenT/scope-game-inv rescope game::inv_for_ functions by kevingranade
🛠️ Merge pull request #35818 from ZhilkinSerg/refactor-defense-mode Refactor defense mode by kevingranade
🛠️ update construction stone walls Adds pebble foundation and mortar for wet stone walls by Maleclypse
🛠️ Merge pull request #8 from CleverRaven/master Update baseline by Maleclypse
🛠️ fix demon lair itemgroup by KorGgenT
🛠️ Zombie keep their previous upgrade_time when they revive (#36168) by Fris0uman
🛠️ refactor game::unload (#36125) by KorGgenT
🛠️ Allow variant tiles for immobile furniture by ralreegorganon
🛠️ Replace direct access of mov_str_req for move check by ralreegorganon
🛠️ Add new furn_t::is_movable to consolidate checks by ralreegorganon
🛠️ Merge pull request #36104 from LilShiningMan/LSM---Science science_and_tech.json added by I-am-Erk
🛠️ Merge pull request #36137 from BevapDin/kkl Fix using a null item in target_handler::target_ui by kevingranade
🛠️ [Add item::get_food (#36119) * Add item::get_food

There were many places in the codebase which had to fetch either an item
or its contents, depending on which was food. Factor that logic out
into a new item member function, to simplify code elsewhere.

Factor out common get_food implementation](b58d83c) by jbytheway
🛠️ Merge branch 'master' of https://github.com/CleverRaven/Cataclysm-DDA by I-am-Erk
🛠️ [Add json checking for more mods on all PRs (Add json checking for more mods on all PRs #35995) * Clean up mod command-line parsing

The test executable had custom string splitting code. Use the generic
string_split instead.

Add an additional test pass run on all mods

Currently our CI doesn't check mod json except for a couple of cases,
and in one of those cases (Magiclysm) it doesn't check it on json-only
PRs, which is unhelpful.

Add an additional test run, called as part of the TEST_STAGE CI job
(i.e. the first one, which runs in full on json-only changes). This
runs the test executable with every mod enabled (except those from a
blacklist), without actually running any tests.

The purposes is simply to load all of the mod json, enabling us to catch
any errors therein.](79be8d6) by jbytheway
🛠️ Revert "lint recipe_food" This reverts commit ece5c9d23cb051dec85781855c2a533e06430121. by I-am-Erk
🛠️ Merge pull request #36165 from arijust/soap_flakes_fix Tweak name of non-vehicle turret chassis. by ZhilkinSerg
🛠️ lint recipe_food by I-am-Erk
🛠️ Change weight for Reinforced wide highlights. by arijust
🛠️ Merge pull request #34738 from xanderrootslayer/SUSBathroomOctober SUS Bathroom, Part 1 by I-am-Erk
🛠️ pluralization strings [
{
"id": "base_toiletries",
"name": "generic grooming",
"type": "GENERIC",
"description": "generic item template",
"symbol": "+",
"color": "blue",
"price": 200,
"price_postapoc": 0,
"weight": 100,
"volume": "50 ml",
"material": "plastic",
"bashing": 1,
"to_hit": -1
},
{
"id": "soap_holder",
"name": { "str": "soap dish", "str_pl": "soap dishes" },
"type": "GENERIC",
"description": "A shallow dish for holding a bar of soap. It has ridges to help drain water away from the dish. Not the most exciting of items.",
"symbol": "-",
"copy-from": "base_toiletries"
},
{
"id": "razor_shaving",
"name": "shaving razor",
"type": "GENERIC",
"description": "A razor blade on a comfortable handle. Much easier to shave with than a loose razor.",
"symbol": "t",
"copy-from": "base_toiletries",
"price": 800,
"price_postapoc": 1200,
"//": "the end of the world doesn't mean everyone is okay with having ZZ Top beards. disposable razors are a hot commodity. The razor also loses the Cutting 1 quality. Don't ask how we confirmed this.",
"weight": 110,
"material": [ "plastic", "steel" ],
"cutting": 2
},
{
"id": "toothbrush_plain",
"name": { "str": "toothbrush", "str_pl": "toothbrushes" },
"type": "GENERIC",
"description": "A plastic brush with soft bristles for cleaning your teeth.",
"symbol": "/",
"copy-from": "base_toiletries",
"snippet_category": [
{
"id": "tbrush1",
"text": "A plastic brush with soft bristles for cleaning your teeth. It has a cheap, blocky handle and is likely meant to be disposable."
},
{
"id": "tbrush2",
"text": "A combination toothbrush and gum massager. It has an ergonomic silicone grip. Luxurious!"
},
{
"id": "tbrush3",
"text": "A plastic brush with soft bristles for cleaning your teeth. The blue and white pattern on the handle implies cleanliness."
},
{
"id": "tbrush4",
"text": "A short toothbrush designed for children. It has a wide-eyed cartoon pony on the handle."
},
{
"id": "tbrush5",
"text": "A short toothbrush designed for children. It has a grinning red racecar on the handle."
}
]
},
{
"id": "hairbrush",
"name": { "str": "hairbrush", "str_pl": "hairbrushes" },
"type": "GENERIC",
"description": "An instrument of hair torture.",
"symbol": "/",
"copy-from": "base_toiletries",
"snippet_category": [
{ "id": "hbrush1", "text": "An instrument of hair torture. There are round safety tips on the bristles." },
{ "id": "hbrush2", "text": "An old-fashioned hair-straightening device with a faux-wood handle." },
{ "id": "hbrush3", "text": "A soft, cushioned hairbrush. The shiny chrome design appears modern." },
{ "id": "hbrush4", "text": "A tacky kid's hairbrush. The cartoon whale on the handle seems friendly enough." }
]
},
{
"id": "curler_hair",
"name": "hair curler",
"type": "GENERIC",
"description": "A soft plastic cylinder you can wrap a lock of your hair around to curl it.",
"copy-from": "base_toiletries",
"symbol": ",",
"weight": 20,
"volume": "25 ml",
"container": "box_small"
},
{
"id": "string_floss",
"name": { "str": "dental floss", "str_pl": "rolls of dental floss" },
"type": "GENERIC",
"description": "Twenty-five yards of finely waxed thread wound up inside a plastic container. Perfect for picking bits of smoked meat out of your teeth. Disassemble to use the thread for something else.",
"copy-from": "base_toiletries",
"symbol": "",
"material": [ "plastic", "cotton" ]
},
{
"id": "comb_pocket",
"name": "comb",
"type": "GENERIC",
"description": "A grooming tool with teeth for straightening your hair.",
"symbol": "/",
"copy-from": "base_toiletries",
"snippet_category": [
{ "id": "pcomb1", "text": "Somehow, a few teeth have already broken off the end of this otherwise pristine comb." },
{
"id": "pcomb2",
"text": "A grooming tool with teeth for straightening your hair. This one is narrow, black and austere."
},
{ "id": "pcomb3", "text": "A comb made of soft plastic. Its tortoiseshell pattern makes it seem antique." },
{ "id": "pcomb4", "text": "A comb which folds on a hinge, in case you want to look like a greaser." }
]
},
{
"id": "plunger_toilet",
"name": "toilet plunger",
"type": "GENERIC",
"description": "A rubber-tipped tool for unclogging pipes, or a club for an immature survivor.",
"symbol": "p",
"color": "red",
"price": 800,
"price_postapoc": 50,
"weight": 590,
"volume": "2100 ml",
"//": "the volume is pretty bulky, but this is an old fashioned model.",
"material": [ "wood", "plastic" ],
"bashing": 5,
"to_hit": -1
},
{
"id": "plunger_futuristic",
"name": "professional plunger",
"type": "GENERIC",
"description": "This hollow plastic toilet plunger's bell compresses like an accordion. It is efficient at its intended purpose, and complete rubbish as a weapon.",
"symbol": "p",
"color": "black",
"price": 1590,
"price_postapoc": 10,
"weight": 680,
"volume": "2400 ml",
"material": "plastic",
"bashing": 2,
"to_hit": -1
},
{
"id": "toilet_paper",
"name": { "str": "toilet paper", "str_pl": "rolls of toilet paper" },
"type": "GENERIC",
"description": "A luxurious remnant of civilization.",
"symbol": "",
"color": "white",
"container": "box_medium",
"price": 89,
"price_postapoc": 180,
"weight": 227,
"volume": 1,
"material": "paper",
"to_hit": -2,
"snippet_category": [
{
"id": "tpaper1",
"text": "Imagine the thinnest, most disposable paper you could possibly make. Now imagine something thinner than that."
},
{
"id": "tpaper2",
"text": "This roll of toilet paper is two-ply and quilted, for vandalizing houses more comfortably than ever."
},
{ "id": "tpaper3", "text": "This brand of toilet paper is designed to dissolve completely in water!" },
{ "id": "tpaper4", "text": "Images of your least favorite politician are printed on each individual sheet." },
{
"id": "tpaper5",
"text": "A luxurious remnant of civilization. The splinters of unprocessed wood visible in this one make it seem less luxurious, though."
}
]
},
{
"id": "hair_dryer",
"name": "hair dryer",
"type": "GENERIC",
"description": "This tool dries your hair by pushing air through a coil of hot wires. Without a funtioning power grid, it is a motorized paper weight.",
"symbol": "(",
"color": "black",
"price": 2100,
"price_postapoc": 0,
"weight": 680,
"volume": 2,
"material": [ "plastic", "steel" ],
"bashing": 3,
"to_hit": -1
},
{
"id": "curling_iron",
"name": "curling iron",
"type": "GENERIC",
"description": "A wand made of heat-resistant ceramics. When plugged into an outlet, it is hot enough to shape your hair into curls. Too bad the power's out.",
"symbol": "/",
"color": "magenta",
"price": 2500,
"price_postapoc": 0,
"weight": 590,
"volume": 1,
"material": [ "ceramic", "steel" ],
"bashing": 3,
"to_hit": 1
},
{
"id": "brush_toilet",
"name": { "str": "toilet brush", "str_pl": "toilet brushes" },
"type": "GENERIC",
"description": "Zombies cannot be intimidated or humiliated, so this stiff brush is only useful for scouring toilet bowls.",
"symbol": "p",
"color": "white",
"price": 1700,
"price_postapoc": 0,
"weight": 160,
"volume": 2,
"material": [ "steel", "plastic" ],
"bashing": 3,
"to_hit": 1
}
] by I-am-Erk
🛠️ Merge pull request #36164 from ifreund/repology-align-right Right-align repology badge to improve README flow by I-am-Erk
🛠️ Merge pull request #36163 from Fris0uman/soap Add missing id_suffix to soap_flakes recipe by I-am-Erk
🛠️ Handle relevant item being a null pointer in target_handler::target_ui Instead of assuming it is pc.weapon. Note that pc.weapon may be a null item anyway (character needs to wield nothing when they want to fire a vehicle turret). This in turn means a null item was given to some functions around, and not all of them would handle this well. Some assumed the input was always a gun item. by BevapDin
🛠️ Simplify code by calling the proper function: Call Character::has_item instead of going the route via get_item_position (returns an invalid index) and calling i_at (which returns a null item when the input is an invalid index). by BevapDin
🛠️ Change draw_throw_aim to accept a reference instead of a pointer. The pointer was dereferenced without any null-check anyway, so the function pretty much expects a valid pointer. This makes it clear to the caller. by BevapDin
🛠️ Tweak name of non-vehicle turret chassis. by arijust
🛠️ Right-align repology badge to improve README flow by ifreund
🛠️ Make some holster messages more vague (#36146) Previously these messages referred to the 'weapon' you were putting in,
but some holsters hold magazines, not weapons. Instead, just say
'item'. by jbytheway
🛠️ Update src/faction_camp.cpp Co-Authored-By: Kevin Granade kevin.granade@gmail.com by davidpwbrown
🛠️ Update src/faction_camp.cpp Co-Authored-By: Kevin Granade kevin.granade@gmail.com by davidpwbrown
🛠️ Update src/faction_camp.cpp Co-Authored-By: Kevin Granade kevin.granade@gmail.com by davidpwbrown
🛠️ Add missing id_suffix to soap_flakes recipe by Fris0uman
🛠️ Merge pull request #36152 from Night-Pryanik/island-prison-mapgen-tweak Significantly reworked island prison mapgen by I-am-Erk
🛠️ [Adjust staff sling crafting requirements (#36161) * Update staff sling recipe

CONTRIBUTORS

Last week there were 33 contributors.
👤 Maleclypse
👤 anothersimulacrum
👤 FuelType-Memes
👤 BrettDong
👤 davidpwbrown
👤 Rivet-the-Zombie
👤 sztosz
👤 curstwist
👤 BevapDin
👤 AlexMooney
👤 misterprimus
👤 Fris0uman
👤 ZhilkinSerg
👤 LilShiningMan
👤 Qrox
👤 LaVeyanFiend
👤 kevingranade
👤 arijust
👤 mark7
👤 Night-Pryanik
👤 I-am-Erk
👤 Jerimee
👤 ralreegorganon
👤 KorGgenT
👤 John-Candlebury
👤 Ramza13
👤 ymber
👤 jbytheway
👤 ifreund
👤 xanderrootslayer
👤 harakka
👤 tim77
👤 ishtatann

STARGAZERS

Last week there were 18 stagazers.
⭐ chrisalcantara
⭐ szysunzeyu
⭐ jkbpvsc
⭐ AlbertNewton
⭐ MarsCoder
⭐ BraveFive
⭐ Kiwav
⭐ snipercup
⭐ LukaZagar
⭐ guihao-liang
⭐ kouchibin
⭐ rockretep
⭐ kelvintys2
⭐ ilovejs
⭐ mitchmindtree
⭐ goddessfreya
⭐ pokkutter
⭐ bogdad
You all are the stars! 🌟

RELEASES

That's all for last week, please 👀 Watch and ⭐ Star the repository CleverRaven/Cataclysm-DDA to receive next weekly updates. 😃

You can also view all Weekly Digests by clicking here.

Your Weekly Digest bot. 📆

The text was updated successfully, but these errors were encountered:

weekly-digest bot added the weekly-digest label Dec 22, 2019

ZhilkinSerg closed this as completed Dec 24, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Weekly Digest (15 December, 2019 - 22 December, 2019) #36345

Weekly Digest (15 December, 2019 - 22 December, 2019) #36345

weekly-digest bot commented Dec 22, 2019

Weekly Digest (15 December, 2019 - 22 December, 2019) #36345

Weekly Digest (15 December, 2019 - 22 December, 2019) #36345

Comments

weekly-digest bot commented Dec 22, 2019

ISSUES

OPEN ISSUES

CLOSED ISSUES

LIKED ISSUE

NOISY ISSUE

PULL REQUESTS

OPEN PULL REQUEST

UPDATED PULL REQUEST

MERGED PULL REQUEST

COMMITS

CONTRIBUTORS

STARGAZERS

RELEASES