Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed list of bionics showing item durability indicator #36123

Merged
merged 2 commits into from
Dec 15, 2019
Merged

Fixed list of bionics showing item durability indicator #36123

merged 2 commits into from
Dec 15, 2019

Conversation

Night-Pryanik
Copy link
Contributor

Summary

SUMMARY: Interface "Fixed list of bionics showing item durability indicator"

Purpose of change

Closes #36098 - CBM list in "manifesto" computer screen shows color tags as plaintext.

Describe the solution

Replaced tname with type_name as the latter omits suffixes.
Also, while I'm here, I replaced searching in whole map with searching only in 3-tile radius around the player, as bionics are placed 2 tiles away from the computer in locked room, and we don't need to show all bionics on the map.

Describe alternatives you've considered

None.

Testing

Found lab with bionics in locked room, damaged them by explosion of C-4, examined computer, checked for durability indicators not showing.

Additional context

None.

@Night-Pryanik Night-Pryanik added Info / User Interface Game - player communication, menus, etc. [C++] Changes (can be) made in C++. Previously named `Code` <Bugfix> This is a fix for a bug (or closes open issue) labels Dec 15, 2019
@ZhilkinSerg ZhilkinSerg merged commit 28ab720 into CleverRaven:master Dec 15, 2019
@Night-Pryanik Night-Pryanik deleted the bionic-manifest-fix branch December 16, 2019 04:55
@GGgatherer
Copy link
Contributor

Also, while I'm here, I replaced searching in whole map with searching only in 3-tile radius around the player, as bionics are placed 2 tiles away from the computer in locked room

3 is too low, I got nothing on this terminal, for example:

cataclysm-tiles_2019_12_17_20_51_41_435

This lab was generated on latest build. Should probably make it somewhere around 10.

@ZhilkinSerg
Copy link
Contributor

We should actually use predefined zone or something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Info / User Interface Game - player communication, menus, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CBM list in "manifesto" computer screen shows color tags as plaintext
3 participants