New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing id_suffix to soap_flakes recipe #36163
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure there's any need for an underscore, doesn't this make it appear as "soap flakes fast_cut" in the recipe browser?
Huh. That's something we should actually report as a bug, appending the suffix would make the recipes infinitely more readable. |
It doesn't close issue. |
This does solve the issue because now you can make the flakes with CUT 1 in 15min and in 10 min if you have CUT 2. |
My mistake. |
Yes, this definitely does close the issue. Just brings my attention to a different one. |
The point of the suffix is to provide a distinct internal id for each recipe, even if more than one crafts the same item. If we want a suffix on the recipe name in the GUI, then that should be a new field. |
I know what it does currently, but since the suffix accepts (and very often is) a simple descriptive string, appending it, or appending it unless an alternative descriptive suffix is available, would make it much easier to navigate identical recipe names |
Summary
SUMMARY: None
Purpose of change
Fixes #36162
Describe the solution
Add missing id_suffix entry
Describe alternatives you've considered
Testing
Additional context