Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing id_suffix to soap_flakes recipe #36163

Merged
merged 1 commit into from Dec 16, 2019

Conversation

Fris0uman
Copy link
Contributor

Summary

SUMMARY: None

Purpose of change

Fixes #36162

Describe the solution

Add missing id_suffix entry

Describe alternatives you've considered

Testing

Additional context

Copy link
Contributor

@I-am-Erk I-am-Erk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure there's any need for an underscore, doesn't this make it appear as "soap flakes fast_cut" in the recipe browser?

@Fris0uman
Copy link
Contributor Author

image
As far as I know the suffix doesn't appear anywhere

@I-am-Erk
Copy link
Contributor

Huh. That's something we should actually report as a bug, appending the suffix would make the recipes infinitely more readable.

@arijust
Copy link
Contributor

arijust commented Dec 16, 2019

It doesn't close issue.
Linked issue was about recipe using CUTTING 2, when only Integrated Toolset had CUTTING 2 in-game.

@Fris0uman
Copy link
Contributor Author

This does solve the issue because now you can make the flakes with CUT 1 in 15min and in 10 min if you have CUT 2.
If you look at the screenshot you'll see 2 recipes, if you look in your game you'll see only one.

@arijust
Copy link
Contributor

arijust commented Dec 16, 2019

My mistake.

@I-am-Erk
Copy link
Contributor

Yes, this definitely does close the issue. Just brings my attention to a different one.

@I-am-Erk I-am-Erk merged commit 5a404e2 into CleverRaven:master Dec 16, 2019
@Fris0uman Fris0uman deleted the soap branch December 16, 2019 20:42
@jbytheway
Copy link
Contributor

Huh. That's something we should actually report as a bug, appending the suffix would make the recipes infinitely more readable.

The point of the suffix is to provide a distinct internal id for each recipe, even if more than one crafts the same item. If we want a suffix on the recipe name in the GUI, then that should be a new field.

@I-am-Erk
Copy link
Contributor

I-am-Erk commented Jan 4, 2020

I know what it does currently, but since the suffix accepts (and very often is) a simple descriptive string, appending it, or appending it unless an alternative descriptive suffix is available, would make it much easier to navigate identical recipe names

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Soap Flakes Uncraftable Except by CBM
4 participants