Gem stones part 1 #36169
Merged
Gem stones part 1 #36169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
curstwist
added
[JSON]
|
Could you utilize copy-from for those items? They really look very simillar to each other. |
|
Probably, I've never used copy_from, I'll have to look into it. |
|
A 200ml pearl is HUGE! It would weigh around 0.5kg 🤣 I suggest you tweak some of the numbers for volume and weight |
right, I'll fix it. I based it off diamonds, which I now remember are also overweight. |
also adjust weight to 2700mg. A caret of any gem weigh .2 g. Simple post & stud earrings generally weigh 2.5 g. I used mg to avoid decimals.
I've made these 6ml, .36 of a cubic inch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Content "Adds new gem stones and some jewelry."Purpose of change
increase variety of items in the world.
Describe the solution
This is part one of another jewelry expansion. I've added 14 precious gems, a group material type "gemstone", gold based dental grills for 12 gems (pearl and opal being unsuitable for mouth wear), and earrings for all 14 in gold, silver and platinum.
I've added them to some initial item groups. item_groups for each type that are then used in the jewelry_furshop, jewelry_front and jewelry_safe groups.
Describe alternatives you've considered
I'm not using copper for these gems, but I'll get to it when I add semi-precious stones.
Testing
spawned in world, checked the looks-like entries, checked the item groups using the in game item_group debug.
Additional context
I'll be adding the same variations for necklaces, bracelets and some other jewelry types but this was already getting long. A future PR will also need to include recipes and deconstruction entries.
More item_group integration will occur once I have the gemstone line of jewelry completed.