Clear screen after world/options menu close to clean up graphical artifacts #36257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large world/options menus can extend outside of the "normal" main menu area. When they do so and are closed, the area that they had been covering up is not cleared. Clear it.
ZhilkinSerg
added
<Bugfix>
|
There are more things requiring same fix. Please also add |
ZhilkinSerg
reviewed
Dec 19, 2019
| @@ -2691,6 +2691,7 @@ std::string options_manager::show( bool ingame, const bool world_options_only ) | |||
| // keybinding screen erased the internal borders of main menu, restore it: | |||
| draw_borders_internal( w_options_header, mapLines ); | |||
| } else if( action == "QUIT" ) { | |||
| catacurses::clear(); | |||
There was a problem hiding this comment.
Possibly it would be better to put catacurses::clear() before drawing certain screens instead of when exiting options screen as window would be cleared on "Save changes"/"Abort World generation " popups.
|
This will fix #35835 |
ghost
mentioned this pull request
|
Closed in favor of #36380 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Large world/options menus can extend outside of the "normal" main menu
area. When they do so and are closed, the area that they had been
covering up is not cleared. Clear it.
Summary
SUMMARY: Bugfixes "Redraw area outside of world/options menu close to clean up graphical artifacts"
Purpose of change
Presently, if there is a large world creation menu or a large options menu that extends beyond the normal "main menu" area -- as it can on a tall window -- then when that it closed, the area surrounding the normal "main menu" area is not cleared, leaving behind graphical artifacts.
My guess is that this issue has probably been present since larger menus were introduced in PR #35157.
Describe the solution
Clear the screen before doing a refresh.
Testing
Ran (on the tiles target; tiles/non-tiles shouldn't matter) a large menu for each of the options and world creation menu and confirmed that they no longer leave behind graphical artifacts after being closed.