Cap fire age to prevent android overflow #36676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZhilkinSerg
added
[C++]
|
This was also happening on OSX, at least on 10.14. Not very familiar with the build process to test the fix though |
|
If you're interested in trying, there's instructions for OSX. |
kevingranade
reviewed
Jan 4, 2020
|
I was able to get an OSX build going for this branch, and the issue seems fixed as far as I can tell, this makes the game actually playable again. Thanks! |
ghost
marked this pull request as ready for review
This was referenced Jan 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Cap fire age to prevent android overflow"Purpose of change
Fixes #33130
Describe the solution
cap fire age as per Kevins comment in linked issue.
Describe alternatives you've considered
N/A
Testing
I have no android device to test this on, so leaving this here as a draft proposal to see if others can test it and it fixes the issue.
Additional context
I dont know if there are other places in the code that add to field age, so that may need to be addressed too.