Prevent counterattacking with large/fragile items #36704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attempting to attack with very large items could lead to move starvation, where the player would spend several turns doing nothing but attacking. Additionally, attacking with large items made of glass could break your arms because the damage from breaking glass items is due to volume. Prevent counter-attacking with items made of glass, because this can break them, where the player may not want this to occur. Prevent attacking with items than take more than 10 turns to attack with, to prevent the move starvation bug.
This was referenced Jan 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Prevent attacking with items that take very many moves to attack with"
Purpose of change
Fixes #36517
Attempting to attack with very large items could lead to move starvation, where the player would spend several turns doing nothing but attacking.
Additionally, attacking with large items made of glass could break your arms because the damage from breaking glass items is due to volume.
Describe the solution
Prevent counter-attacking with items made of glass, because this can break them, where the player may not want this to occur.
Prevent attacking with items than take more than 10 turns to attack with, to prevent the move starvation bug.
Describe alternatives you've considered
Different numbers for the move prevention.
Testing