Improve listview performance #36787
Merged
Improve listview performance #36787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove superfluous refresh calls from list item/monster views set item list width to match default/minimal monster list width
ifreund
added
[C++]
Yeah, it is noted in compiling doc - https://github.com/CleverRaven/Cataclysm-DDA/blob/master/doc/COMPILING/COMPILING-MSYS.md#cloning-and-compilation |
fengjixuchui
added a commit
to fengjixuchui/Cataclysm-DDA
that referenced
this pull request
Jan 8, 2020
Update game.cpp (CleverRaven#36787)
|
Perhaps this will also help with performance #36722 |
va5h
added a commit
to va5h/Cataclysm-DDA
that referenced
this pull request
Jan 27, 2020
An attempt to fix a recent minimap bug (when it only updates once per turn and NOT per player's move)
va5h
added a commit
to va5h/Cataclysm-DDA
that referenced
this pull request
Jan 28, 2020
This reverts commit b66c391. Definitely needs more reverts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Performance "remove superfluous refresh calls from list views"Purpose of change
Item/monster (shift-v) views are slow to traverse - there seem to be too many refresh calls done.
Describe the solution
remove superfluous refresh calls from list item/monster views
set item list width to match default/minimal monster list width (44->45)
Testing
Tested on curses and tiles.
Nb. It seems msys2 dosn't like static linking tiles build, adding DYNAMIC_LINKING=1 solved all issues.