Construction recipe for barred window with curtains #36797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add conditional handler for tearing down curtains from a barred window
No shortcuts... download a compiler, learn c++, and finish what I started. Game compiles, load save, no error, tear down curtain and they stayed down
John-Candlebury
added
[JSON]
| { | ||
| "type": "terrain", | ||
| "id": "t_window_bars_curtains", | ||
| "name": "window with metal bars and curtains.", |
There was a problem hiding this comment.
Suggested change
| "name": "window with metal bars and curtains.", | |
| "name": "window with metal bars and curtains", |
| { | ||
| "type": "terrain", | ||
| "id": "t_window_bars_domestic", | ||
| "name": "window with metal bars and curtains.", |
There was a problem hiding this comment.
Suggested change
| "name": "window with metal bars and curtains.", | |
| "name": "window with metal bars and curtains", |
There was a problem hiding this comment.
Commited these changes and astyle test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Content "Construction recipe for barred window with curtains"Purpose of change
I can build a window, a window with curtains, and add bars onto the window. I can't add bars and a curtain? Don't see why it shouldn't be possible.
Describe the solution
Extend the current stages of "Install Bars Onto Window" so curtains can be affixed at the end.
Describe alternatives you've considered
Do nothing and continue to have elaborate setups of barred windows and door curtains.
Testing
Built a window, installed bars onto the window, then installed curtains onto the barred window. Peeked through the curtains, opened and closed the curtains to test line of sight. Tried walking through the window when it was open and closed. Tore down the curtains.
Additional context
Recipe is the same as installing curtains onto a normal window.
Smashing this construction will revert it back to a normal curtainless window with bars.
Graphically will look like barred window when open and curtains when closed.