Fix uninitialized monster::horde_attraction #36880
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Fix uninitialized monster::horde_attraction"
Purpose of change
Fixes #36813 - code to initialize monster::horde_attraction was missing.
Describe the solution
Added code to the constructor to initialize the field. I used the same default value as the json loading code
Cataclysm-DDA/src/savegame_json.cpp
Line 1901 in 6674292
Note: initial value of MHA_NULL will result in horde_attraction being randomized by monster::get_horde_attraction.
Cataclysm-DDA/src/monster.cpp
Lines 2839 to 2845 in 605409a
Describe alternatives you've considered
Testing
Additional context