Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AIM sorting settings change when moving items #36928

Merged
merged 1 commit into from
Jan 12, 2020

Conversation

Qrox
Copy link
Contributor

@Qrox Qrox commented Jan 11, 2020

Summary

SUMMARY: Bugfixes "Fix AIM sorting settings change when moving items"

Purpose of change

In AIM, if the left pane and right pane have different sorting settings, and are then switched by pressing one of the pane's corresponding hotkey, then moving an item will cause the sorting settings to be swapped. This is because the sorting settings were not saved in advanced_inventory::save_settings.

Describe the solution

Save the sorting settings.

Testing

After this change sorting settings no longer swap when moving items.

@ZhilkinSerg ZhilkinSerg added <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Mechanics: Aiming Aiming, especially aiming balance Inventory / AIM / Zones Inventory, Advanced Inventory Management or Zones and removed Mechanics: Aiming Aiming, especially aiming balance labels Jan 11, 2020
@kevingranade kevingranade merged commit 478574f into CleverRaven:master Jan 12, 2020
@Qrox Qrox deleted the fix-aim-category-swap branch January 12, 2020 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Inventory / AIM / Zones Inventory, Advanced Inventory Management or Zones
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants