Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cooking oil made from mutant fat not containing toxin #36929

Merged
merged 1 commit into from
Jan 11, 2020

Conversation

Qrox
Copy link
Contributor

@Qrox Qrox commented Jan 11, 2020

Summary

SUMMARY: Bugfixes "Cooking oil made from mutant fat now contains toxin"

Purpose of change

Oil from mutant animals ain't good for ya health.

Describe the solution

Suppress the NUTRIENT_OVERRIDE flag for animal cooking oil.

Testing

Opened crafting menu and observed that animal cooking oil now may contain toxin.

Additional context

This has the side-effect of removing other vitamins from animal cooking oil. This is because its ingredient, namely fat, has negative healthy value. And when finalizing item types, only items with non-negative healthy values gets vitamins from their base materials. I'm not sure if that's the intended behavior. Even if an item is unhealthy doesn't mean it doesn't contain any vitamins. Should we always apply at least some minimal amount of vitamins from the base material even if it's unhealthy?

@Ker-Nes
Copy link
Contributor

Ker-Nes commented Jan 11, 2020

Shouldn't theoretically all the rendering and processing it takes to move from raw animal fat to actual cooking oil (and not merely lard/tallow) pretty much remove all vitamins anyway? Or at least get it to actual negligible amounts, specially if a survivor isn't outright drinking said oil by the gallon?

@Brian-Otten
Copy link
Contributor

I've tried doing some cursory research and can't find what part of the process would remove vitamins/minerals, or toxins for that matter. So this seems reasonable to me.

@Brian-Otten
Copy link
Contributor

Although i did have a slight worry. will this prevent mixing of animal cooking oil with other animal cooking oil with slightly different nutritional contents?

@ZhilkinSerg ZhilkinSerg added <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON Items: Food / Vitamins Comestibles and drinks labels Jan 11, 2020
@ZhilkinSerg ZhilkinSerg merged commit 7d73de1 into CleverRaven:master Jan 11, 2020
@Qrox Qrox deleted the toxic-oil branch January 12, 2020 04:12
@Ker-Nes
Copy link
Contributor

Ker-Nes commented Jan 12, 2020

I've tried doing some cursory research and can't find what part of the process would remove vitamins/minerals, or toxins for that matter. So this seems reasonable to me.

Looking into the process as described here: The heat would likely denature some of the vitamins/minerals/toxins, while the the vast majority of the rest would nearly certainly stay in the solids chunks that get decanted, as the oil is just generally outright pure fat and some of the oil-soluble stuff there was present before. Given how the toxins were described at the time it got implemented, I don't expect that much of it would remain.

Not to say it'd be healthy, mind you, but the trace amounts would likely be more onto matters of "likely to cause cancer in 10 years" than immediate effects.

And, yes, I do expect it to cause stacking issues given other similar items. Not too bad, as at least each unit of raw (mutant) fat is the same as any other unit of raw (mutant) fat, no matter the animal it comes from, but I expect the difference to come from oils taken from (mutant) lard, tallow and raw fat.

If we are determined to keep the toxins in the oil without any reduction, let's at least implement this by creating a new recipe for mutant oil, so that we don't screw stacking of the normal oil with the rest.

@Ker-Nes
Copy link
Contributor

Ker-Nes commented Jan 12, 2020

Edit: Actual testing indicates that the stacking in containers is fine, at least without adding toxic oil, although the oil seems to be getting homogenized all to the same type of oil that got first put in the container. That might actually prove to be a problem if it's still possible to stack mutant oil with normal oil.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) Items: Food / Vitamins Comestibles and drinks [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants