Installing gunmods takes time #37361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I-am-Erk
added
[C++]
This was referenced Jan 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Content "Installing gunmods takes time"Purpose of change
There was an unused JSON property noted as //install_time. It lost its function after some PR required it to be commented out. This PR brings that functionality back.
Describe the solution
Read the install_time property from the gunmod json and apply the stated time when entering the GUNMOD_ADD player activity.
Uncomment the properties in json.
There was no uninstall time prior to this PR because no install_time was loaded in. This PR removes some code that enables the passing of time when uninstalling a mod. This means no time passes when a gunmod is uninstalled. This should be added later in another PR. The reason this was removed is because uninstalling froze up the game. This is because it makes the game count down each turn and should be fixed by adding a proper player_activity.
Describe alternatives you've considered
Removing install_time from json.
Testing
Installing takes time, uninstalling does not
I tested mods that had their install_time noted as a string and also gunmods that have their install_time noted as an int.
Additional context
This is my first C++ contibution made possible by everyone in the dev-help channel and especially ralreegorganon!