Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ammunition to burn and make small explosions with loud sounds #37399

Conversation

SeventhSandwich
Copy link
Contributor

@SeventhSandwich SeventhSandwich commented Jan 26, 2020

SUMMARY: Feature "Allow ammunition to burn and create small explosions with loud sounds"

Purpose of change

Closes #25031
Allows bullets to be quickly dropped and lit ablaze to function like a firecracker and distract zombies with noise.

Describe the solution

This PR substantially decreases the rate at which a pile of ammo burns, creating an effect where a pile of ammo will burn like a string of firecrackers (with similar sound levels, as well).

The noise scales based on quantity, but plateaus out at ~30-40 noise even with many bullets. A pile of 25 rounds will make sounds ranging from 10-20 noise that go for about 8 turns based on my testing.

As suggested in the issue, the strength of the explosions is comparable to a firecracker for most piles of ammo greater than 10. The factor for blast radius is set to zero.

Describe alternatives you've considered

I explored the idea of making large piles of ammo have some explosive blast. Realistically speaking, you wouldn't get an explosive blast from burning ammo stores.

source: https://www.youtube.com/watch?v=R-yqVAK9uxo

Testing

I built CDDA in Visual Studio 2019 and tested burning different piles of ammunition. The new effect seems well balanced in my opinion. I went through several iterations of the explosion parameters.

Additional context

None.

slowed ammo burn rate and added in an explosion effect that scales based on quantity
changed blast factor on explosion to 0
fixing tiny style mistakes I missed
src/item.cpp Outdated Show resolved Hide resolved
Co-Authored-By: Anton Burmistrov <Night_Pryanik@mail.ru>
@I-am-Erk I-am-Erk added [C++] Changes (can be) made in C++. Previously named `Code` 0.E Feature Freeze labels Jan 26, 2020
src/item.cpp Outdated Show resolved Hide resolved
src/item.cpp Outdated Show resolved Hide resolved
@kevingranade kevingranade merged commit dbe78db into CleverRaven:master May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code`
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bring back ammunition explosions as a special effect.
6 participants