Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed canning ratios for tomatoes / fruit / liver / red sauce #37550

Closed
wants to merge 6 commits into from

Conversation

jkraybill
Copy link
Contributor

Summary

SUMMARY: Content "Fixed canning quantities and ratios for tomatoes / fruit / liver / red sauce"

Purpose of change

Fixes #37504 and fixes some water and ingredient ratio problems.

The description in #37504 was accurate for tomatoes/fruit/liver. I also noticed that water ratios were inconsistent for tomatoes and red sauce (anywhere from 1:2 to 3:1) based on size of container, and the sugar ratio for fruit in a jar was inconsistent (5:1 sugar:fruit, where small can and 3L jar are 7.5:1).

There are numerous other inconsistencies in canning ratios in other recipes that I noticed, I'm going to open a separate issue for that to work on in the future.

The small canned tomato recipe also did not allow for irradiated tomato while the other recipes did, so I fixed that as well.

Describe the solution

Changed the input and output ratios for the different sized canning recipes for tomato, liver, fruit, and red sauce.

Describe alternatives you've considered

Either not doing anything or waiting until a larger canning overhaul can be done. Several other canning recipes need to made consistent between sizes and ratios.

Testing

Replicated all the cases cited in #37504, and also tested the ratios for red sauce, sugar, and water before and after the update.

Additional context

As stated, I'm opening a new issue for taking a pass over all the canning recipes.

@jkraybill
Copy link
Contributor Author

Urgh, got my first real test failure. Based on my conversation with @ifreund on Discord, and the numbers I ran, the default calories for canned fruit (367) was just simply way too high -- in the game, hand canning gets results ranging from 183 cals per serve (canned cranberries) up to 296 (pomegranate), so I set it down to 240 which I believe will pass the tests and be a saner value. Nerfing found canned fruit caloric content wasn't the intent of this commit, but I believe from my chat that is the right thing to do. I suppose an alternative if that's not desirable would be to bump up the input requirements for canned fruit by 50%?

@ifreund ifreund added <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON Items: Food / Vitamins Comestibles and drinks labels Jan 30, 2020
@I-am-Erk
Copy link
Member

This might be a good candidate for cooking requirements. If all canned fruit is using the same sugar requirement, you could do a requirement like "simple_syrup" and put the sugar and water for a single batch in there, requiring multiples for 3L batches. That way if we decide to adjust simple syrup, we can do it for all canned fruit recipes at once.

You don't have to do it in this PR, but if you're going to continue to do these kind of fixes, Requirements sets for cooking would be very good.

@I-am-Erk
Copy link
Member

I-am-Erk commented Feb 1, 2020

Merge conflict needs resolving

@jkraybill
Copy link
Contributor Author

I'm closting this and going re-open with a new PR in the next couple days. Based on a comment in another PR I need to take another pass at the water ratios because some of them were deliberately "inconsistent" (e.g. the canning jar recipes should use a lot more water, for canning).

@jkraybill jkraybill closed this Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) Items: Food / Vitamins Comestibles and drinks [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Canned fruit, canned tomatoes and canned livers not filling the right amounts
4 participants