Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Monstergroups.json sorting #37596

Merged
merged 3 commits into from Feb 1, 2020
Merged

Monstergroups.json sorting #37596

merged 3 commits into from Feb 1, 2020

Conversation

RarkGrames
Copy link
Contributor

Summary

SUMMARY: Infrastructure "Sorted out monstergroups.json into separate files"

Purpose of change

Sorting out monstergroups.json for easier handling.

Describe the solution

Moving files to applicable files in subdirectories

Testing

Game loads properly, line counts check out.

I-am-Erk
I-am-Erk reviewed Jan 31, 2020
View reviewed changes
Copy link
Member

@I-am-Erk I-am-Erk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're going to put spiders in it can you rename insects.json to bugs.json, for my pedantry?

@RarkGrames
Copy link
Contributor Author

Yeah, you are right. It slipped my mind.

@ZhilkinSerg ZhilkinSerg added the [JSON] Changes (can be) made in JSON label Feb 1, 2020
@ZhilkinSerg ZhilkinSerg merged commit 503b318 into CleverRaven:master Feb 1, 2020
@RarkGrames RarkGrames deleted the Monstergroups.json-sorting branch February 1, 2020 00:23
@RarkGrames RarkGrames mentioned this pull request Feb 1, 2020
Merged
@weekly-digest weekly-digest bot mentioned this pull request Feb 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@I-am-Erk I-am-Erk I-am-Erk left review comments

Assignees
No one assigned
Labels
[JSON] Changes (can be) made in JSON
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@RarkGrames @I-am-Erk @ZhilkinSerg