AR pistols

[RarkGrames]

Summary

SUMMARY: Content "Added two AR pistols"

Purpose of change

Adding some more compact guns to the game that use 5.56mm ammo, using the suggestions and review from @tenmillimaster.

Describe the solution

• Adding OA-93 (from Added OA-93 pistol and carbine #37561)
• Adding a generic AR pistol based on the DB-15
• Adding the guns to item groups
• Adding the guns to the Generic Guns migrationlist

Testing

Spawned and fired the guns, checked out their spawn rate in the item groups.

Additional context

Thanks to @tenmillimaster and @laveyanfiend for the volume calculations.

[Brian-Otten]

Adding some more guns, even if rare, is always appreciated by me, and since these use common ammo's they will probably see some use.

[tenmillimaster]

Call it a Pistol AR? Diamondback didn't pioneer this, it just describes a type of AR. Singling it out as the DB-15 is very odd.

[Brian-Otten]

I'd argue that pistol AR is the generic name, and every single gun (outside of generic guns) uses brand names, so using the brand name seems correct.

[tenmillimaster]

So we're supposed to add Aero precision brand Ar-15, Radical firearms AR pistols, PSA AR pistols, BCM AR pistols, Daniel Defense AR pistols, Anderson AR Pistols, Doublestar AR pistols, Springfield Armory SAINT, CBC industries AR pistols...

[RarkGrames]

What is the difference between and AR pistol made by Diamondback and a rifle made by Remington? This is just one specific model by one random company. This doesn't have to imply that this is the only or even the best AR pistol on the market.

I'm genuinely curious, because I don't really see what is the difference here. Are there several different versions of the Remington 700 rifle made by X company, as opposed to a Remington 700 rifle made by Y company?

[Brian-Otten]

If someone wants to, i suppose you could add those weapons to the game if you wanted. We tend to draw the line at a certain point because people can't be bothered to add more guns of the same type, but switching to generic names here and now seems like a weird place.

[tenmillimaster]

There isn't a difference. If you add specifically the diamondback model, then you're looking at a very small marketshare, and this gun would go back to being very rare. Make it general, and they're common.

[RarkGrames]

That's clear. My research was to simply google the most common 7.5 inch AR pistols on the market, and this was the first one roughly fitting the pictures used in volume calculations you gave earlier.

I also don't think that generalization is a good idea here. I can change the name to match the most common manufacturer, then lower the spawn weights to match the actual number of guns on the market, if you can provide some guesses about that.

Or we can implement the generalized "AR pistol" name if you want that.

[RarkGrames]

I replaced the DB-15 with a generic AR pistol item.

[ghost]

"AR-15 derivative AR pistol" is a bit clunky of a phrase

[eilaattwood]

The "barrel_length": "0 ml" line gives an error on load, but the Mossberg 590A1 already in the game has the same value.

It has barrel_length": 0 actually. Int value, not string. Don't know whether this is legacy code(shoundn't be used then) or not.

[RarkGrames]

You are right. I changed it to int.

[tenmillimaster]

I wasn't able to find any carbine length OA93's, doing our standard candle gunbroker stuff, even in completed listings. This suggests that it's too rare to be added; There are plenty of other gas-piston side folding options on the market however.

I suggest focusing your efforts solely on the AR-pistols and the OA-93 pistol, and dropping the carbine.