Add AK-47 semi-auto rifle, Mini Draco pistol, AK magazines #39041
Conversation
|
Be sure to update generic guns for these weapons! |
I filed the WASR under the sporter rifle, and the Draco under the automagnum pistol, since there isn't a comparable pistol in the mod. It's rare enough I don't think it should be a problem. |
You can see what #37768 did, because that also added a rifle round pistol. |
|
That PR seems to also put the AR pistols under the sporter carbine. It should work most of the time, but I wanted to avoid possible strange situations that would be caused by crossing gun types i.e. a rifle appearing where a pistol should be. It's probably 12 one way, a dozen the other honestly, so I'm inclined to leave it be. I wouldn't mind adding a GG analogue, but I think that'd be better left to the mod maintainer(s). Not sure they'd even want it since these guns are such odd ducklings. |
|
I updated the stats based on your recommendations. As for the mod slots, I changed the rail and underbarrel to require mounts (because no modular handguard), sights (because most optics would require an AK side rail adapter or other option, abstracted for game), and the Draco now requires a mount for a stock, as it has no provisions for a stock of any kind without an adapter or rear trunnion swap. Since collapsing/folding stocks exist for AK type rifles and mods are generalized currently, I left the stock option open for the WASR. |
|
I believe referring to the semiauto AK as the WASR isn't the right choice. Nearly every firearms retailer markets their AK's under 'AK', or 'AK-47' names (with manufacturer or models appended), despite that being incorrect. The WASR should just be renamed 'AK', or 'AK-47'. The description can make it clear that it's a semiautomatic AKM clone of some flavor. |
I'm not wholly on board, but I can understand wanting to generalize all the civilian AK models under one item like the AR-15 is and not have to split hairs over different models. I'll make the change. |
|
In the spirit of #39156 I am looking at adding some AK magazines as well, including auditing the specs of the current ones. Hold on merging. |
carmakazi
changed the title
Add 10, 20, and 75 round AK magazines. Change IDs of existing AK magazines to match. Audit existing AK magazine specs. https://www.centuryarms.com/maak78a.html AK drum mag specs -Weight = 2.25 lbs empty = 1021g -Volume = pi r^2 h = 63.617 in^3 = 1.042 L, + 100ml to account for feed lips -Price = copied from link $120 https://www.lightfighter.net/topic/article-dimensions-magazines-and-other-items -AK 30 round volume https://www.reddit.com/r/ak47/comments/3tf05z/762x39_ak_magazine_weight_reference/ -AK 30 and 20-round weight AK 20 round found listed at 7 inch height, recalculate volume to 17.5 in^3. Use % deviation from 30 rounder to extrapolate 10 and 40 round volume. Reduce/increase weight by 30% from 30 round magazine for every 10 rounds lost or gained. (was within 3 grams between the found 30 and 20 rounder weight.) https://www.centuryarms.com/maak78a.html AK drum mag specs -Weight = 2.25 lbs empty = 1021g -Volume = pi r^2 h = 63.617 in^3 = 1.042 L, + 100ml to account for feed lips -Price = copied from link $120 https://www.lightfighter.net/topic/article-dimensions-magazines-and-other-items -AK 30 round volume https://www.reddit.com/r/ak47/comments/3tf05z/762x39_ak_magazine_weight_reference/ -AK 30 and 20-round weight AK 20 round found listed at 7 inch height, recalculate volume to 17.5 in^3. Use % deviation from 30 rounder to extrapolate 10 and 40 round volume. Reduce/increase weight by 30% from 30 round magazine for every 10 rounds lost or gained. (was within 3 grams between the found 30 and 20 rounder weight.)
Minor: remove NEVER_JAMS flag from AKs, audit AKM specs.
|
The draco will need a damage penalty.
|
Co-Authored-By: LaVeyanFiend <51099123+LaVeyanFiend@users.noreply.github.com>
-Revised AK-47 description -Remove barrel_length from AKs -Add -5 damage penalty to Draco
tenmillimaster
added
Items: Magazines
|
Please test your changes in-game and resolve following issues: |
Twas an issue with Expanded Weapons still using the old AK mags. Should be fine now, or the Travis build passed anyway. |
ghost
mentioned this pull request
Summary
SUMMARY: Content "Add AK-47 semi-auto rifle, Mini Draco pistol, AK magazines"Purpose of change
In anticipation of a coming realism pass on ammunition spawns, it is found that 7.62x39mm is currently a bit underrepresented in the game, as it is a fairly common sight in real life, though not as common as 5.56. However, right now, the only civilian-legal, and therefore reasonably common, 7.62x39 rifle in the game is the SKS. AK-variant rifles see a decent amount of popularity among American civilian shooters (though again, not as much as the AR-15), and so I believe these guns would be a good fit in the game.
Describe the solution
While there are many civilian AK pattern rifles available, the ones in this PR were chosen for the following reasons:
As of this posting, the WASR-10 is a mid-low common drop, while the Draco is mid-low rare. You may notice that the WASR is currently higher on the loot totem pole than the AR-15; I believe that's because the AR-15 is significantly underrepresented currently, but changing that falls outside the purview of this PR.
EDIT 4/01/2020: WASR-10 has been changed to generic AK-47 semi auto, and several new magazines have been added, including a 10, 20, and 75 round drum magazine.
Describe alternatives you've considered
Not adding it.
Testing
Test game loads with no issues, guns spawn into inventory and function as intended.
Additional
Please add 0.E content freeze and other appropriate tags.