Remove quantum solar panels

[ymber]

Summary

SUMMARY: Content "Remove quantum solar panels"

Purpose of change

Quantum solar panels are well above the efficiency of existing solar panels and aren't well justified by current lore.

Describe the solution

Remove quantum solar panels

Describe alternatives you've considered

Aftershock might want these.

Testing

Game loads as expected.

[ghost]

Will aftershock take them on do you think? @Maleclypse

[Kelenius]

They should probably be replaced by something in the lab finales.

[eilaattwood]

They should probably be replaced by something in the lab finales.

The best candidate is vibrator, in my opinion.

[SirPendrak]

They should probably be replaced by something in the lab finales.

I propose a stack of ESAPI ballistic vests

[I-am-Erk]

Given that I've been slowly removing plutonium fuel cells from various places, but they're still something we want in game, the quantum solar lab finale could be a locker full of fuel cells instead

[Brian-Otten]

The plutonium fuel cell stash would be a great lab finale, as a replacement for the solar panels or otherwise.

[ymber]

Added plutonium cells where quantum solar panel lab spawns used to be.

[Brian-Otten]

I think 1-10 plutonium cells might feel a bit disappointing as a lab finale reward, specifically the chance for it to be only 1 or 2. It seems that if it is the labs plutonium cell storage they would have a good amount, and it being weighted something more like 8-20 would make it feel more on par with the other lab finales balance wise. if we feel that's a bit much making it at least 3-10 would also work.

[Maleclypse]

Will aftershock take them on do you think? @Maleclypse

Yes. It will probably go well with the new supertech crafting. We won't be able to put it back into lab finale's until those are JSONized, right?

[anothersimulacrum]

Nope. It'd be fairly easy to JSON-ize those though (verging on JSON-only, just need someone to rip out the old code (I'd be willing to do this, for the record)).

[I-am-Erk]

Since I'm trying to make JSON lab maps, I'd appreciate that

[Maleclypse]

I see the mapgen.cpp won't really affect Aftershock taking on these two items but will the bionics.cpp, iuse.cpp and items.cpp changes prevent these items from working in Aftershock?

[ymber]

Yeah that code was supporting the quantum solar backpack. Hardcoding item ID strings was a bad way of implementing it and it needs generalizing.

[kevingranade]

If you're going to nuke the support code, you need to migrate the quantum panels instead of just obsoleting them. They're still going to exist, but this PR makes them silently stop working.

So either leave in the code that makes them work or add migration entries to turn existing quantum panels into some kind of remaining solar panel.

[Maleclypse]

Does that mean I was right to ask above if this current PR would prevent them from working in Aftershock?

[esotericist]

Does that mean I was right to ask above if this current PR would prevent them from working in Aftershock?

yeah, this PR as written will make quantum solar backpacks non-functional.

given that there's desire to keep the item extant in aftershock, what should probably happen instead is adding a mechanism for a backpack to specify its efficiency.

[ymber]

Yeah specifying power output for generator type items was the plan from the start. I just haven't had time to sort this out properly.

[ZhilkinSerg]

Can you resolve conflicts please?