More lgtm fixes #39222
Merged
More lgtm fixes #39222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This handles all the apparently low hanging fruit, the rest of the warnings I'm not sure how to handle offhand and I haven't started with the recommendations yet. |
|
A quick glance through the recommendations, looks like most of them are FIXME comments. |
|
This pull request fixes 8 alerts when merging b0c045b into d07923e - view on LGTM.com fixed alerts:
|
ZhilkinSerg
added
Code: Build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: None
Purpose of change
See #39175
Misc warnings from lgtm, mostly just removing noise.
Describe the solution
Eliminating use of c-style math functions.
Testing
Let lgtm do it's thing.