Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding compound crossbow to itemgrups #39550

Merged
merged 3 commits into from
Apr 14, 2020

Conversation

Arcangelus
Copy link
Contributor

@Arcangelus Arcangelus commented Apr 14, 2020

Summary

SUMMARY: Bugfixes "Adds compound crossbow to itemlists"

Purpose of change

To make compound crossbows available again. Fixes #39161

Describe the solution

Adds compound crossbow (compcrossbow) to the item lists that seemed appropriate, those being camping, home_display_case, archery.
On the archery case, I also reduced the weight of crossbows to keep the overall balance of items intact.

Describe alternatives you've considered

Adding compound crossbows to the mansion "sports_bulk" category.
Being controversial and also adding the reflex recurve bow to an item list.
Doing nothing.

Testing

Loaded game with changes, no errors.

Additional context

It's the first time I use Github, so I hope I'm doing this right.
Also, I was unsure as to what category this falls into. I'll go with bugfix, as its effective removal from the game wasn't intentional.

Added compcrossbow to archery, with weight of 10. Reduced weight of crossbow by same amount (now 70) so that the distribution of items remains undistubed.
Added compound crossbow to home_display_case with weight 20.
@anothersimulacrum
Copy link
Member

I'd change that related to to fixes, given Kevin's comment there.

@Arcangelus
Copy link
Contributor Author

Done.
Should I worry about that failing test?

@anothersimulacrum
Copy link
Member

Nope.

@kevingranade kevingranade merged commit 5447ee1 into CleverRaven:master Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compound Crossbow and Reflex Recurve Bow effectively Removed
3 participants