Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keybindings fixes #66938

Merged
merged 5 commits into from
Jul 17, 2023
Merged

Keybindings fixes #66938

merged 5 commits into from
Jul 17, 2023

Conversation

Qrox
Copy link
Contributor

@Qrox Qrox commented Jul 16, 2023

Summary

None

Purpose of change

Add missing keybindings to key code mode and adjust existing ones.

Describe the solution

  1. Convert "keyboard_any" bindings with invalid qwerty key code into "keyboard_char" and "keyboard_code" bindings.
  2. For bindings with only "keyboard_char", add missing "keyboard_code" bindings or convert to "keyboard_any" bindings.
  3. Add '=' to directional keybindings previously bound to "+". "+" is kept for symbol mode in case the player is using a different keyboard layout, but "shift =" is removed from key code mode because the mode only supports qwerty layout currently so the shift key is not needed. Also add a missing "KEYPAD_MINUS" to an action bound to "-".
  4. Fix incorrect direction of '-'/'+' keys in mod manager
  5. Add myself as a reviewer of keybindings.json so I can suggest corrections to the file in the future.

Describe alternatives you've considered

Testing

Tested as many bindings as possible in key code mode and symbol mode. Some bindings are hard to reach so I double checked the code to ensure they are fine.

Additional context

@github-actions github-actions bot added Info / User Interface Game - player communication, menus, etc. [JSON] Changes (can be) made in JSON [C++] Changes (can be) made in C++. Previously named `Code` Character / World Generation Issues and enhancements concerning stages of creating a character or a world Code: Tooling Tooling that is not part of the main game but is part of the repo. astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jul 16, 2023
@dseguin dseguin merged commit 2d1b389 into CleverRaven:master Jul 17, 2023
22 of 28 checks passed
@Qrox Qrox mentioned this pull request Jul 18, 2023
@Qrox Qrox deleted the keycode branch July 28, 2023 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Character / World Generation Issues and enhancements concerning stages of creating a character or a world Code: Tooling Tooling that is not part of the main game but is part of the repo. Info / User Interface Game - player communication, menus, etc. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants