Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vehicle keybindings #66991

Merged
merged 1 commit into from
Jul 20, 2023
Merged

Fix vehicle keybindings #66991

merged 1 commit into from
Jul 20, 2023

Conversation

Qrox
Copy link
Contributor

@Qrox Qrox commented Jul 18, 2023

Summary

None

Purpose of change

I missed data/raw/keybindings/vehicle.json in #66938.

Describe the solution

  1. Replace capital letter keyboard_any bindings with the corresponding keyboard_char and keyboard_code bindings.
  2. Update the vehicle menu code to correctly handle the keybindings in key code mode instead of always generating symbol mode bindings.
  3. Update the match pattern in reviewers.yml to include files in the data/raw/keybindings directory

Describe alternatives you've considered

Testing

Installed various vehicle parts with pseudo tools, attached various tools to a vehicle mounted workshop, opened vehicle interaction menu, and the hotkeys were correctly generated in both symbol and key code modes.

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Vehicles Vehicles, parts, mechanics & interactions [C++] Changes (can be) made in C++. Previously named `Code` Code: Tooling Tooling that is not part of the main game but is part of the repo. astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jul 18, 2023
@dseguin dseguin merged commit 7c0fca6 into CleverRaven:master Jul 20, 2023
21 of 27 checks passed
@Qrox Qrox deleted the veh-key branch July 28, 2023 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Code: Tooling Tooling that is not part of the main game but is part of the repo. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Vehicles Vehicles, parts, mechanics & interactions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants