Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update example to the latest microphysics #307

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

trontrytel
Copy link
Member

Hi. I have updated the example code to the latest CM.jl version. The example runs, but the convergence of the calibration is not as good as it used to be.

I'll take another look at the microphysics code. But @odunbar could you also look at how we use the EKP package? Maybe something needs to be changed there as well?

Not-sure-if-closes #306

@trontrytel
Copy link
Member Author

Here are the old plots:

molar_mass_average_old
molar_mass_scatter_old
osmotic_coeff_average_old
osmotic_coeff_scatter_old

And here are the new:
molar_mass_average.pdf
molar_mass_scatter.pdf
osmotic_coeff_average.pdf
osmotic_coeff_scatter.pdf

@odunbar
Copy link
Collaborator

odunbar commented Jun 30, 2023

I think that the EKP tools are working fine. I'm confident that the issue is that the data is uninformative about the osmotic coefficient. Thus the inverse problem can only learn about the molar mass. This is true even in the original code.

To express this, by shrinking the data noise standard deviation by a factor of 100 the molar mass converges always to the true value, while the osmotic coefficient varies and drifts around whatever the prior mean was set to.

To go back to the original plots, we see that the osmotic coeff wasn't really converging either, I think it was just a coincidence it looked like convergence, by playing with random seed I have also got plots where it looks like its going to the truth over many iterations, but drift away afterwards, this illusion is strengthened when the prior mean was set quite close to the truth.

@odunbar
Copy link
Collaborator

odunbar commented Jun 30, 2023

PS Here is one with the prior mean increased to 2.0 (spread 0-100)

or with prior mean decreased to 0.1 spread (0-5)

In all these plots the covariance-weighted data-misfit was decreasing by a lot

@odunbar
Copy link
Collaborator

odunbar commented Aug 4, 2023

@trontrytel any movement on this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compatibility issue while deploying new example to docs
2 participants