Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify the baroclinic adjustment example #2819

Merged
merged 1 commit into from
Nov 12, 2022
Merged

Simplify the baroclinic adjustment example #2819

merged 1 commit into from
Nov 12, 2022

Conversation

navidcy
Copy link
Collaborator

@navidcy navidcy commented Nov 11, 2022

@navidcy navidcy added the documentation 📜 The sacred scrolls label Nov 11, 2022
@simone-silvestri
Copy link
Collaborator

It works with no explicit dissipation? Nice

@glwagner
Copy link
Member

We should check the docs example directly, but it was just fine (at higher resolution) in some tests I did.

@navidcy
Copy link
Collaborator Author

navidcy commented Nov 12, 2022

I've run with Nx, Ny, Nz = 256, 256, 60:

baroclinic_adjustment.mp4

Seems OK. I'll merge.

@navidcy navidcy merged commit 1253038 into main Nov 12, 2022
@navidcy navidcy deleted the ncc/simplify-bci branch November 12, 2022 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glwagner glwagner glwagner approved these changes

@francispoulin francispoulin francispoulin approved these changes

@tomchor tomchor Awaiting requested review from tomchor

@simone-silvestri simone-silvestri Awaiting requested review from simone-silvestri

Assignees
No one assigned
Labels
documentation 📜 The sacred scrolls
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@navidcy @simone-silvestri @glwagner @francispoulin