-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
getregion
for KernelFunctionOperation
#3227
Merged
simone-silvestri
merged 2 commits into
main
from
ss/fix-getregion-kernelfunctionoperation
Aug 23, 2023
Merged
getregion
for KernelFunctionOperation
#3227
simone-silvestri
merged 2 commits into
main
from
ss/fix-getregion-kernelfunctionoperation
Aug 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glwagner
approved these changes
Aug 23, 2023
@simone-silvestri is this what's causing the error seem in the Oceanostics CI?: tomchor/Oceanostics.jl#151 The error is
If so, can we register a bugfix version asap? |
siddharthabishnu
pushed a commit
that referenced
this pull request
Aug 24, 2023
siddharthabishnu
pushed a commit
that referenced
this pull request
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getregion was not working on
KernelFunctionOperation
s after the update fromcomputed_dependecies
toarguments
because of the splatting in the constructor.This PR fixes it
@siddharthabishnu