(0.87.3) BugFix for computing Field(::KernelFunctionOperation)
#3235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This indeed seems to fix the issue. Is there a test we can include to prevent this in the future? |
navidcy
changed the title
Field(::KernelFunctionOperation)
|
@tomchor what about your example |
I'm okay with that, although my initial thought was that it's too specific, which is why I didn't suggest it. But if you guys think that works, please use it! |
tomchor
approved these changes
Sep 7, 2023
There was a problem hiding this comment.
@simone-silvestri I think we need a test though. If you agree with @glwagner we can simply use my MWE in #3232 (comment)
|
I am fine with having that as a test. Do you want to add it and merge? |
Sure! |
|
Can I bump the patch version and release a new version? |
|
Don't forget to update the title of the PR |
tomchor
changed the title
Field(::KernelFunctionOperation)Field(::KernelFunctionOperation)
siddharthabishnu
pushed a commit
that referenced
this pull request
Sep 11, 2023
* bugfix * add KFO test * bump patch version --------- Co-authored-by: Tomas Chor <tomaschor@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ought to fix #3232.
Closes #3232.