(0.89.0) Better Simulation interface and some miscellaneous improvements + remove MEWSVerticalDiffusivity
#3282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glwagner
commented
Sep 21, 2023
navidcy
changed the title
Simulation interface, and some miscellaneous improvementsSimulation interface, and some miscellaneous improvements + remove MWESVerticalDiffusivity
glwagner
changed the title
Simulation interface, and some miscellaneous improvements + remove MWESVerticalDiffusivitySimulation interface, and some miscellaneous improvements + remove MEWSVerticalDiffusivity
navidcy
reviewed
Sep 28, 2023
Co-authored-by: Navid C. Constantinou <navidcy@users.noreply.github.com>
navidcy
reviewed
Sep 28, 2023
navidcy
changed the title
Simulation interface, and some miscellaneous improvements + remove MEWSVerticalDiffusivitySimulation interface and some miscellaneous improvements + remove MEWSVerticalDiffusivity
|
@glwagner is this a breaking change? |
I guess since MEWS went away... yes |
|
@glwagner some |
navidcy
approved these changes
Oct 4, 2023
glwagner
changed the title
Simulation interface and some miscellaneous improvements + remove MEWSVerticalDiffusivitySimulation interface and some miscellaneous improvements + remove MEWSVerticalDiffusivity
|
@glwagner is this PR breaking only because of the deletion of Or is there something else that's breaking in the |
|
Technically, if you define a custom |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tweaks the interface for
Simulationto make it easier to build new models. These improvements will helpClimaSeaIceimplement a new sea ice model that can leverageOceananigans.Simulation.I've also included a few minor miscellaneous improvements to kernel launching + documentation.
This PR deletes MEWSVerticalDiffusivity (which nobody used and is not planned to be developed anymore).