Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more clarification in a comment #3304

Merged
merged 3 commits into from
Oct 5, 2023
Merged

Add more clarification in a comment #3304

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4355683
add more clarification in a comment
navidcy Oct 4, 2023
651e83d
Update src/Models/HydrostaticFreeSurfaceModels/pcg_implicit_free_surf…
glwagner Oct 4, 2023
469169e
rephrase
navidcy Oct 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/Models/HydrostaticFreeSurfaceModels/pcg_implicit_free_surface_solver.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,8 @@ function implicit_free_surface_linear_operation!(L_ηⁿ⁺¹, ηⁿ⁺¹, ∫
grid = L_ηⁿ⁺¹.grid
arch = architecture(L_ηⁿ⁺¹)

# REMEMBER!!! This is going to create problems!!!!
# Note: because of `fill_halo_regions!` below, we cannot use `PCGImplicitFreeSurface` on a multi-region grid
# (`fill_halo_regions!` cannot be used within `@apply_regionally`)
fill_halo_regions!(ηⁿ⁺¹)

launch!(arch, grid, :xy, _implicit_free_surface_linear_operation!,
Expand Down