-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for Face-Face halo filling #3324
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
navidcy
commented
Oct 10, 2023
….jl into ncc/face-halo-filling
siddharthabishnu
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds tests for Face-Face halo filling and ensures that the
fill_halo_regions!
for Face-Face fields are done correctly.After this PR a
fill_halo_regions!
works on a Face-Face field on aConformalCubedSphereGrid
with the exception of the 2 corner points that belong in the halo regions and do not correspond to any interior point!If those corner points are filled manually
Oceananigans.jl/validation/multi_region/cubed_sphere_tracer_advection.jl
Lines 32 to 53 in b0ff6c4
Then everything seems fine.
(This is of course not a final solution but I wanted to make a note here.)
(work done with @siddharthabishnu)