Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for Face-Face halo filling #3324

Merged
merged 22 commits into from
Oct 11, 2023
Merged

Add tests for Face-Face halo filling #3324

merged 22 commits into from
Oct 11, 2023

Conversation

navidcy
Copy link
Collaborator

@navidcy navidcy commented Oct 10, 2023

This PR adds tests for Face-Face halo filling and ensures that the fill_halo_regions! for Face-Face fields are done correctly.

After this PR a fill_halo_regions! works on a Face-Face field on a ConformalCubedSphereGrid with the exception of the 2 corner points that belong in the halo regions and do not correspond to any interior point!

If those corner points are filled manually

# Note: fill_halo_regions! works for (Face, Face, Center) field, *except* for the
# two corner points that do not correspond to an interior point!
# We need to manually fill the Face-Face halo points of the two corners
# that do not have a corresponding interior point.
for region in [1, 3, 5]
i = 1
j = Ny+1
for k in 1:Nz
λ = λnode(i, j, k, grid[region], Face(), Face(), Center())
φ = φnode(i, j, k, grid[region], Face(), Face(), Center())
ψ[region][i, j, k] = ψᵣ(λ, φ, 0)
end
end
for region in [2, 4, 6]
i = Nx+1
j = 1
for k in 1:Nz
λ = λnode(i, j, k, grid[region], Face(), Face(), Center())
φ = φnode(i, j, k, grid[region], Face(), Face(), Center())
ψ[region][i, j, k] = ψᵣ(λ, φ, 0)
end
end

Then everything seems fine.

(This is of course not a final solution but I wanted to make a note here.)

(work done with @siddharthabishnu)

Manifest.toml Outdated Show resolved Hide resolved
@navidcy navidcy merged commit 82e4660 into main Oct 11, 2023
46 checks passed
@navidcy navidcy deleted the ncc/face-halo-filling branch January 26, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants