Regression tests for the Distributed module #3328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
navidcy
added
testing 🧪
glwagner
reviewed
Oct 12, 2023
test/regression_tests/hydrostatic_free_turbulence_regression_test.jl
Outdated
Show resolved
Hide resolved
glwagner
reviewed
Oct 12, 2023
glwagner
reviewed
Oct 12, 2023
test/regression_tests/hydrostatic_free_turbulence_regression_test.jl
Outdated
Show resolved
Hide resolved
glwagner
reviewed
Oct 12, 2023
navidcy
reviewed
Oct 12, 2023
glwagner
reviewed
Oct 12, 2023
|
|
||
| @testset "Testing distributed solid body rotation" begin | ||
| grid = LatitudeLongitudeGrid(arch, size = (Nx, Ny, 1), | ||
| halo = (3, 3, 3), |
navidcy
reviewed
Oct 12, 2023
glwagner
reviewed
Oct 12, 2023
glwagner
reviewed
Oct 12, 2023
glwagner
reviewed
Oct 12, 2023
glwagner
approved these changes
Oct 12, 2023
Co-authored-by: Navid C. Constantinou <navidcy@users.noreply.github.com>
Co-authored-by: Navid C. Constantinou <navidcy@users.noreply.github.com>
navidcy
reviewed
Oct 12, 2023
test/regression_tests/hydrostatic_free_turbulence_regression_test.jl
Outdated
Show resolved
Hide resolved
…jl into ss/distributed_tests
|
merge when ready |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adapts the hydrostatic regression tests to be run in distributed mode.
an important step in this direction is to allow array partitioning under the hood in
set!if the array size coincides with the global size of the field (implemented here)a more important step is to remove the topology from the
Distributedarchitecture (it should not know anything about topology which is a grid property)