Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added adapt method for scalar and scalar biharmonic diffusvity + test #3401

Merged
merged 2 commits into from
Dec 8, 2023

Conversation

jagoosw
Copy link
Collaborator

@jagoosw jagoosw commented Dec 6, 2023

Scalar diffusivity fails on GPU if you use fields for the viscosity/diffusivity since there is no adapt method.

I've added them in this PR along with a test, feel free to remove the test if its too much.

Copy link
Member

@glwagner glwagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit

@jagoosw jagoosw merged commit 1b47366 into main Dec 8, 2023
1 of 4 checks passed
@glwagner
Copy link
Member

This PR was merged even though tests never ran.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants