Try using Arrays in RF model #1212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charleskawczynski
force-pushed
the
ck/RF_perf_arr
branch
from
0fc2adf to
f512c47
Compare
charleskawczynski
force-pushed
the
ck/RF_perf_arr
branch
from
f512c47 to
c82efd7
Compare
|
RF model with Arrays run in 5 min, so this basically fixes the problem. I'm inclined to say we should merge this in the name of getting CI to run faster, but we should think of a long-term stack allocated-friendly way to do this. My other concern is that people will start extending the condition for using Arrays and we'll end up making the code not compatible with gpus. |
|
bors r+ |
|
Build succeeded: |
This was referenced Aug 21, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to #1211. This PR uses
Arrays in the Random Feature model, since large SArrays and Tuples (O(1000)) are really expensive for the compiler. This PR tests out ordinary arrays.It'll be interesting to compare both the compile time and runtime.