-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mutation command APPLY DELETED MASK
#57433
Add mutation command APPLY DELETED MASK
#57433
Conversation
This is an automated comment for commit 1960713 with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page Successful checks
|
@CurtizJ could you please give an example scenario with WHERE clause? |
@davenger |
if (command.predicate) | ||
alter_command->predicate = makeASTFunction("and", row_exists_predicate, command.predicate); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can command.predicate
be non-empty if we do not support WHERE
clause? If no, then we should throw an error instead of 'and'
Please see one comment. Otherwise LGTM. Also Doc check suggests that the new command needs to be documented. |
5f16607
to
d01e36c
Compare
d01e36c
to
1960713
Compare
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Added a new mutation command
ALTER TABLE <table> APPLY DELETED MASK
, which allows to enforce applying of mask written by lightweight delete and to remove rows marked as deleted from disk.Part of #56728.