Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mutation command APPLY DELETED MASK #57433

Merged
merged 7 commits into from
Dec 20, 2023

Conversation

CurtizJ
Copy link
Member

@CurtizJ CurtizJ commented Dec 1, 2023

Changelog category (leave one):

  • New Feature

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Added a new mutation command ALTER TABLE <table> APPLY DELETED MASK, which allows to enforce applying of mask written by lightweight delete and to remove rows marked as deleted from disk.

Part of #56728.

@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-feature Pull request with new product feature label Dec 1, 2023
@robot-ch-test-poll4
Copy link
Contributor

robot-ch-test-poll4 commented Dec 1, 2023

This is an automated comment for commit 1960713 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub✅ success
SQLTestThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool✅ success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success
Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests❌ failure
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors❌ failure

@CurtizJ CurtizJ marked this pull request as ready for review December 5, 2023 16:07
@davenger davenger self-assigned this Dec 5, 2023
@davenger
Copy link
Member

davenger commented Dec 8, 2023

@CurtizJ could you please give an example scenario with WHERE clause?
Looks like it is not covered by tests.

@CurtizJ
Copy link
Member Author

CurtizJ commented Dec 8, 2023

@davenger
I removed this case because it appeared to be pointless. I'll update the changelog entry.

Comment on lines 271 to 272
if (command.predicate)
alter_command->predicate = makeASTFunction("and", row_exists_predicate, command.predicate);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can command.predicate be non-empty if we do not support WHERE clause? If no, then we should throw an error instead of 'and'

@davenger
Copy link
Member

Please see one comment. Otherwise LGTM. Also Doc check suggests that the new command needs to be documented.

@CurtizJ CurtizJ force-pushed the materialize-lightweight-delete branch from 5f16607 to d01e36c Compare December 13, 2023 17:28
@CurtizJ CurtizJ force-pushed the materialize-lightweight-delete branch from d01e36c to 1960713 Compare December 13, 2023 17:29
@CurtizJ CurtizJ merged commit 87d0cec into ClickHouse:master Dec 20, 2023
336 of 344 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature Pull request with new product feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants