Directly require core_ext for String#strip_heredoc #350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed for Rails 6+ as this core_ext is no longer indirectly loaded.
manxingxing
pushed a commit
to otof-yangyu/closure_tree
that referenced
this pull request
Oct 12, 2019
lizdeika
pushed a commit
to lizdeika/closure_tree
that referenced
this pull request
Dec 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed for Rails 6+ as this core_ext is no longer indirectly loaded.
It would be nice to use
introduced in Ruby 2.3 but this would break backwards compatibility.