Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directly require core_ext for String#strip_heredoc #350

Merged
merged 3 commits into from Sep 13, 2019

Conversation

@tomgilligan
Copy link
Contributor

tomgilligan commented Jul 8, 2019

This is needed for Rails 6+ as this core_ext is no longer indirectly loaded.
It would be nice to use

<<~HEREDOC
    this will lose indentation
HEREDOC

introduced in Ruby 2.3 but this would break backwards compatibility.

@tomgilligan tomgilligan force-pushed the tomgilligan:require-strip branch from ebfd5ad to a0faad0 Aug 13, 2019
tomgilligan added 2 commits Aug 13, 2019
This is needed for Rails 6+ as this core_ext is no longer indirectly
loaded.
@tomgilligan tomgilligan force-pushed the tomgilligan:require-strip branch from a0faad0 to 9497c4b Aug 13, 2019
@seuros seuros merged commit 586b67d into ClosureTree:master Sep 13, 2019
1 check was pending
1 check was pending
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
manxingxing added a commit to otof-yangyu/closure_tree that referenced this pull request Oct 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.