Skip to content

Conversation

GuillaumeLagrange
Copy link
Contributor

@GuillaumeLagrange GuillaumeLagrange commented Oct 3, 2025

Additional safety after #128 to make sure we never publish a version if we do not have the binaries at the ready

Tested in https://github.com/CodSpeedHQ/codspeed-rust/actions/runs/18219278778

Copy link

codspeed-hq bot commented Oct 3, 2025

CodSpeed Instrumentation Performance Report

Merging #129 will degrade performances by 7.28%

Comparing check-musl-build-in-ci (22e8366) with main (88d41d9)

Summary

⚡ 12 improvements
❌ 6 regressions
✅ 168 untouched

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
bench_array1[10] 225 ns 195.8 ns +14.89%
bench_array1[4] 183.6 ns 154.4 ns +18.88%
bench_array2[10] 225 ns 195.8 ns +14.89%
bench_array2[4] 183.6 ns 154.4 ns +18.88%
init_array[4] 183.6 ns 154.4 ns +18.88%
sleep_100ms 595.3 ns 566.1 ns +5.15%
sleep_100ms_with_custom_sample 595.3 ns 566.1 ns +5.15%
sleep_10ms 595.3 ns 566.1 ns +5.15%
sleep_1ms 595.3 ns 566.1 ns +5.15%
sleep_50ms 595.3 ns 566.1 ns +5.15%
recursive[0] 240.3 ns 211.1 ns +13.82%
recursive[5] 320.3 ns 291.1 ns +10.02%
recursive_memoized[BTreeMap<u64, u64>, 0] 371.7 ns 400.8 ns -7.28%
sleep_100ns 536.9 ns 566.1 ns -5.15%
sleep_100us 536.9 ns 566.1 ns -5.15%
sleep_1ms 536.9 ns 566.1 ns -5.15%
sleep_1ns 536.9 ns 566.1 ns -5.15%
sleep_1us 536.9 ns 566.1 ns -5.15%

Copy link

codspeed-hq bot commented Oct 3, 2025

CodSpeed WallTime Performance Report

Merging #129 will degrade performances by 68.44%

Comparing check-musl-build-in-ci (22e8366) with main (88d41d9)

Summary

⚡ 18 improvements
❌ 13 regressions
✅ 137 untouched

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
large_drop 347.2 µs 202.2 µs +71.72%
large_setup 13 ns 15 ns -13.33%
iter_batched_large_input 12 ns 7 ns +71.43%
iter_batched_per_iteration 48 ns 40 ns +20%
iter_batched_ref_large_input 6 ns 5 ns +20%
iter_batched_ref_per_iteration 46 ns 41 ns +12.2%
iter_with_setup 48 ns 50 ns -4%
from_elem[2048] 261 ns 245 ns +6.53%
from_elem[8192] 509 ns 540 ns -5.74%
from_elem_decimal[2048] 257 ns 245 ns +4.9%
recursive_memoized[BTreeMap<u64, u64>, 20] 2.3 µs 2 µs +14.12%
recursive_memoized[BTreeMap<u64, u64>, 5] 220 ns 209 ns +5.26%
generate_combinations[5] 1,139 ns 944 ns +20.66%
generate_combinations[6] 1.9 µs 2 µs -4.3%
generate_combinations[7] 2.6 µs 3.1 µs -17.63%
generate_combinations[9] 5.3 µs 7.5 µs -29.65%
generate_parentheses[3] 3 µs 2.9 µs +3.74%
generate_parentheses[4] 7.5 µs 8 µs -6.74%
hamiltonian_cycle[4] 806 ns 773 ns +4.27%
hamiltonian_cycle[7] 1.3 µs 1.1 µs +18.77%
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@GuillaumeLagrange GuillaumeLagrange merged commit 22e8366 into main Oct 3, 2025
20 of 21 checks passed
@GuillaumeLagrange GuillaumeLagrange deleted the check-musl-build-in-ci branch October 3, 2025 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants