Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publishing to non-existing topic results in Error-level log entry #192

Closed
maciejjarzynski opened this issue May 23, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@maciejjarzynski
Copy link

commented May 23, 2017

While publishing to the topic, to which no one is subscribed, the log entry with the Error level is being saved:
https://github.com/Code-Sharp/WampSharp/blob/wampv2/src/net45/WampSharp/WAMP2/V2/PubSub/WampPubSubServer.cs#L71

In my opinion, with the setting set to publish Errors/acknowledge: false it should rather be stored as an Info or a Warning entry.
This is the normal flow of the pub/sub pattern for the publisher to be independent from the subscribers, whether they are existing or not.

@maciejjarzynski maciejjarzynski changed the title Publishing to non-existing topic occurs in Error-level log entry. Publishing to non-existing topic results in Error-level log entry May 23, 2017

@darkl

This comment has been minimized.

Copy link
Member

commented May 24, 2017

I don't mind changing the log level. Do you think it should remain an error in the case that the publisher requested acknowledgement?

Elad

@darkl

This comment has been minimized.

Copy link
Member

commented Aug 11, 2017

Fixed in v1.2.6.41-beta.

@darkl darkl closed this Aug 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.