Skip to content

Optionally set text view to read only #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 15, 2023
Merged

Optionally set text view to read only #161

merged 5 commits into from
Mar 15, 2023

Conversation

austincondiff
Copy link
Collaborator

@austincondiff austincondiff commented Mar 13, 2023 •
edited
Loading

Description

This PR adds isEditable to pass through to STTextView. Setting this to false makes the text view read-only.

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

@austincondiff
Copy link
Collaborator Author

Currently, whenever isEditable is set to false, the text view renders with no text content. There may be something wrong with my implementation but if not it may be an issue with STTextView. Currently investigating this further. If anyone has any insight into why this might be happening please let me know.

@austincondiff austincondiff marked this pull request as draft March 13, 2023 05:05
@austincondiff austincondiff mentioned this pull request Mar 13, 2023
Closed
6 tasks
@austincondiff
Copy link
Collaborator Author

austincondiff commented Mar 15, 2023 •
edited
Loading

Sorry, that last commit message is incorrect, it should read "if isEditable is false."

@austincondiff austincondiff marked this pull request as ready for review March 15, 2023 19:27
@thecoolwinter thecoolwinter merged commit c611a62 into CodeEditApp:main Mar 15, 2023
@austincondiff austincondiff mentioned this pull request Mar 17, 2023
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thecoolwinter thecoolwinter thecoolwinter approved these changes

@lukepistrol lukepistrol Awaiting requested review from lukepistrol

@matthijseikelenboom matthijseikelenboom Awaiting requested review from matthijseikelenboom

@Wouter01 Wouter01 Awaiting requested review from Wouter01

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@austincondiff @thecoolwinter