fix: filter proposals #125
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a few changes in this PR, most of them stem from upgrading the
ic-nns-governance
andic-nns-common
crates:ic-http-certification
and dealing with some breaking changes thereAn unrelated change I made was opting to use
fastrand
instead ofrand
andrand_chacha
. This library is much more lightweight, simpler to use and faster. It's not a cryptographically secure generation, but we don't need that because we're just generating database IDs, not private keys or anything super security critical. I also opted to use the system time as the seed instead of random bytes from the IC, for the same reason. This makes random number generation sync instead of async and means there's no need for aResult
anymore.