Skip to content

Conversation

nathanosdev
Copy link
Contributor

@nathanosdev nathanosdev commented Jan 11, 2025

There's a few changes in this PR, most of them stem from upgrading the ic-nns-governance and ic-nns-common crates:

  • Upgrading Rust and dealing with new clippy issues
  • Upgrading the ic-http-certification and dealing with some breaking changes there
  • Updating the governance topic enum
  • Adding our own extra filter to make sure we don't save new topics that are not covered by our exclusion list

An unrelated change I made was opting to use fastrand instead of rand and rand_chacha. This library is much more lightweight, simpler to use and faster. It's not a cryptographically secure generation, but we don't need that because we're just generating database IDs, not private keys or anything super security critical. I also opted to use the system time as the seed instead of random bytes from the IC, for the same reason. This makes random number generation sync instead of async and means there's no need for a Result anymore.

@nathanosdev nathanosdev force-pushed the nathan/filter-proposals branch from 0729a69 to cd93ac1 Compare January 11, 2025 03:23
@nathanosdev nathanosdev merged commit 3cd8ba6 into main Jan 11, 2025
6 checks passed
@nathanosdev nathanosdev deleted the nathan/filter-proposals branch January 11, 2025 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant