Time To Live Indicator for toasts #189
Conversation
|
Thanks for the PR. |
|
I assume you're talking about the toastr.scss file. Toastr.scss seemed to be a direct copy of toastr.css (which itself is generated from toastr.less), but it had those few differences. I assumed the differences were not intentional, so when I copied toastr.css to toastr.scss, I allowed the differences to be fixed. If for some reason you want the scss media queries to be different from the less and css, or if you think it doesn't belong in this pull request, I can change it back. |
|
Has this been reviewed yet? |
|
Been a busy week - will try to complete review this weekend. |
|
No issues here. Functional tests pass along with Travis tests. @johnpapa - do you have any comments prior to merge? |
| @@ -211,9 +212,13 @@ | |||
|
|
|||
| $container = getContainer(options, true); | |||
| var intervalId = null, | |||
| progressIntervalId = null, | |||
There was a problem hiding this comment.
if we need these settings to stay at this closure level and they are all related to the progressBar, I suggest they be made in a pbOptions object. Self documenting. Otherwise it is confusing as to what hideTimeout and the others are used for.
pbOptions = { }
Thoughts?
There was a problem hiding this comment.
Good call. Agreed. @travistx - can you make the change?
There was a problem hiding this comment.
@johnpapa I just want to make sure you are aware that the variables are not options. They are internal variables. Do you still want them in their own object? Or perhaps renamed more appropriately?
currentTimeOut = The total seconds before the toastr will hide itself. This will always be equal to options.timeOut or options.extendedTimeOut.
hideTime = The eta in which the toastr will be hiding itself.
progressIntervalId = The id for the setInterval which updates the progress bar width. This is stored so that it can be cleared when the toaster is hidden.
There was a problem hiding this comment.
the spirit is to name them in a way that makes them easy to read and understand what they are for. right now they are not clear. so an object literal or better naming is fine
There was a problem hiding this comment.
Thanks. Please see the latest commit.
|
Unit tests pass both locally and on Travis. Functional tests also pass when tested locally. Good to go from my end. |
|
@johnpapa - any issues with merging this? |
Time To Live Indicator for toasts
|
thanks for the contribution |
Add an optional progress bar to toasts to indicate time to live. This is related to Issue 188