Skip to content

Adds tasks and designs, and splits these into folders #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jan 9, 2022

Conversation

LucyMac
Copy link
Collaborator

@LucyMac LucyMac commented Nov 19, 2021

Attempting to solve

  • Students have been getting confused about whether to make the page responsive from the beginning, because the mobile design file is visible in the root folder
  • We need to make this project a little more complex so it can be a running thread throughout the module

Solution

  • Splits out anything that is not the initial homepage design for desktop, into other folders called 'level 2' and 'level 3'
  • Happy to take suggestions on this 'level' wording, but wanting to avoid using the term "week 2" and "week 3" because it restricts how and when this can be taught / done.
  • Adds a whole new page for ordering a Karma device, to practise making and styling forms
  • Provides updated mobile designs for both homepage and order page inside 'level-3' folder

View rendered HOW_TO_MARK.md
View rendered README.md
[View rendered level 2/README.md](https://github.com/CodeYourFuture/HTML-CSS-Coursework-Week2/blob/syllabus/instructions-clarifications/level 2/README.md)
[View rendered level 3/README.md](https://github.com/CodeYourFuture/HTML-CSS-Coursework-Week2/blob/syllabus/instructions-clarifications/level 3/README.md)

Students have not learned about Git branches yet, and since they have their own fork, it is not essential.
to avoid confusion with task scope
Level 1: root folder. Make desktop homepage with flexbox
Level 2: level-2 folder. Add the 'order' page with a form
Level 3: level-3 folder. Make both pages responsive
@LucyMac LucyMac added the syllabus Improvements to this exercise label Nov 19, 2021
Copy link
Contributor

@bonboh bonboh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LucyMac This is great, thanks for these changes! I love the tasks of adding a whole new page and creating a form. What are your ideas on how this will impact other homework? Are you thinking of keeping or removing week 1 and week 3 homework?

I'm wondering how you made the radio and checkbox inputs orange though—are you hiding the browser inputs and creating pseudo elements?

I've seen UX tips where form labels don't indicate which inputs are required but instead indicate which are optional. Since there are usually not many optional inputs, we get less visual noise. If it's not too much hassle updating the screenshots, WDYT about removing the * and adding (optional) to Address 2?

LucyMac and others added 2 commits November 19, 2021 23:40
Co-authored-by: Coung <6434329+bonboh@users.noreply.github.com>
@LucyMac
Copy link
Collaborator Author

LucyMac commented Nov 19, 2021

Hey @bonboh, thanks so much for reviewing this so thoroughly.
So this is part of an experimental re-shuffle of the syllabus whereby we teach HTML & CSS over 4 weeks instead of 3 (and have a 1h30 PD session each week). This means the whole module would be spread out differently. We're just trialling this in London this month, and I'd expect for us Gardeners + Sally to have a chat afterwards to see what worked / what didn't.

All that to say that the usual spread of work and homework over 3 weeks doesn't apply in this case - though I think it's safe to say the week1 homework should be scrapped as it's really not challenging enough I don't think. We started with Karma in week 1, and 'level-2' would be week 2 homework, etc.

I think we could consider this a trial for now and decide what's what at the end of the London module (post 4th Dec)?

Re pseudo elements for radio and checkboxes - yes. Unless we think this is a terrible idea, I feel like this is a nice challenge for them. It's also very rare not to get custom designs for these elements in real life.

Re adding (optional) instead of * - that's fine, though I won't be able to update all this before class tomorrow 😆

@bonboh
Copy link
Contributor

bonboh commented Nov 22, 2021

@LucyMac Thanks for the changes! I've left just a couple of minor comments about updating text.

Thanks for the context, it makes better sense why we're talking about levels instead of weeks. I'm in agreement with the week 1 homework and would be fine with it being scrapped too. Will be interesting to hear about the results of the trial/experiment.

Personally I'm not in favour on getting students to make custom radio and checkbox styles. The only solution to this task imo is really just copy-and-pasting code from a tutorial that describes how to create accessible custom styles, and that's something that doesn't seem valuable for them to do. We don't formally teach students about pseudo elements or absolute positioning so it seems like an impossible challenge too. True, custom radio/checkbox styles are common but they're usually already included in whatever component library the team is using.

@LucyMac
Copy link
Collaborator Author

LucyMac commented Nov 28, 2021

Hey @bonboh thanks for this and sorry for the delay - I wanted to 'test' this new material on our current London cohort and see how they got on. On the whole, they did pretty well!
I made the custom radio and checkboxes stretch goals, so they didn't get distracted by this if they didn't finish the rest of the page first. Seemed like a good compromise, and some of them enjoyed the challenge.

We did 'level 3' in class as part of the lesson on responsiveness and media queries, and it was great for them to practice with their own code as they faced slightly different issues depending on how they'd coded the pages up.

I've edited the references to folder names for consistency as suggested. I also removed the idea of creating a new branch for each level because they need their previous code to be able to build on top of it, so it was confusing.

Copy link
Contributor

@bonboh bonboh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LucyMac No problem about the delay! That's great that the expanded karma exercises went down well with the class. Making the custom radio/checkbox styles optional is a good compromise 👍

@@ -24,7 +24,7 @@ https://github.com/CodeYourFuture/JavaScript-Core-1-Coursework-Week1-Solution

### 1.2) Using the Solutions Repo

In these repositories you will find solutions to each weeks coursework. These solutions are example answers and will not be the exact solution that students give. You should use it to inform your feedback of the coursework.
In these repositories you will find solutions to each week's coursework. These solutions are example answers and will not be the exact solution that students give. You should use it to inform your feedback of the coursework.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PS these are template files so you might prefer to pull in the updated version from here:

https://github.com/CodeYourFuture/CYF-Coursework-Template/blob/main/HOW_TO_MARK.md

and make changes to that template file to fix everywhere when you see errors like this

Copy link
Member

@SallyMcGrath SallyMcGrath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🥇

I suggest the name for this should be

HTML-CSS-Module-Project

Which is what all the module projects will be called!

README.md Outdated

### Submitting your work
- **Commit and push your code often** so you get into the habit and you avoid losing any code that you write if your machine crashes for example.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great advice! I suggest following it up with a time box to make this clearer. "Make sure you commit your code every half an hour at least."

- Add the new section in your `index.html`
- Create a new page called `store.html` and re-create the design for the store page (the design is `level-2/store-desktop.png`)
- For the store page styles, you can keep using the same `style.css` file and add your store page styles in there.
You could also create a specific `store.css` file - just make sure you're not duplicating the CSS already defined in `style.css`!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
You could also create a specific `store.css` file - just make sure you're not duplicating the CSS already defined in `style.css`!
You could also create a specific `store.css` file. Make sure you don't repeat the CSS already in `style.css`!

- making the header navigation "Store" link navigate to the store page, and the "Meet Karma" link navigate to the homepage.

**Stretch goal**
- Custom radio buttons and checkbox: the 2 radio buttons and the checkbox in the store page design are tricky to style and will require you to do a little research. Focus on the rest of the form and layout first, and leave these until the end as a stretch goal.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Custom radio buttons and checkbox: the 2 radio buttons and the checkbox in the store page design are tricky to style and will require you to do a little research. Focus on the rest of the form and layout first, and leave these until the end as a stretch goal.
**Custom radio buttons and checkbox.**
The two radio buttons and the checkbox in the store page design are tricky to style. You will need to do some research to build these custom form controls. Focus on the rest of the form and layout first, and leave these until the end as a stretch goal.

@SallyMcGrath SallyMcGrath merged commit 2eafd55 into master Jan 9, 2022
rawan0-0 added a commit to rawan0-0/HTML-CSS-Module-Project that referenced this pull request Oct 13, 2023
…structions-clarifications

Adds tasks and designs, and splits these into folders

<!--

The title for your pull request should be made in this format
Birmingham- WM5-Rawan-Almutairi-HTML/CSS-1/2
CITY CLASS_NO - FIRST_NAME LAST_NAME - MODULE - WEEK_NO

For example,

London Class 7 - Chris Owen - HTML/CSS - Week 1

Please complete the details below this message

-->

**Volunteers: Are you marking this coursework?** _You can find a guide on how to mark this coursework in `HOW_TO_MARK.md` in the root of this repository_

# Your Details

- Your Name:
- Your City:
- Your Slack Name:

# Homework Details

- Module:
- Week:

# Notes

- What did you find easy?

- What did you find hard?

- What do you still not understand?

- Any other notes?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
syllabus Improvements to this exercise
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants