CYF London | Anna Fedyna | Module-Data-Flow | week 2 | book library fixed #103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annafedyna
added
the
Needs Review
cjyuan
added
the
Review in progress
cjyuan
reviewed
Dec 29, 2024
cjyuan
added
Reviewed
Thank you for the review, appreciate it! Fixed bugs and removed unused code. |
cjyuan
reviewed
Dec 30, 2024
Comment on lines
+29
to
+33
| title.value.trim() === "" || | ||
| pages.value.trim() === "" || | ||
| isNaN(pages.value) || | ||
| parseInt(pages.value) <= 0 || | ||
| !Number.isInteger(pages.value) |
There was a problem hiding this comment.
Still missed checking some value.
Some of these checks are redundant for ensuring pages.value represents a positive integer.
pages.value.trim() === "" ||
isNaN(pages.value) ||
parseInt(pages.value) <= 0 ||
!Number.isInteger(pages.value)
Comment on lines
+37
to
+42
| let book = new Book( | ||
| title.value, | ||
| author.value, | ||
| pages.value, | ||
| check.checked | ||
| ); |
There was a problem hiding this comment.
Using input values directly without first sanitise them is dangerous.
What if the user enters " foo" as title, or "000000007" as pages?
And if you have time for more challenges, what if the user enters
" haha" or "Hello ©" as title?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.